openstack/glance
Code Issues Proposed changes
7d8aa54c75
glance/HACKING.rst
Nguyen Van Trung 97dbfb02d7 Add doc8 to pep8 check for glance project 
This patch adds a doc8 check of .rst files to the current pep8 check.
It includes fixes to the .rst files that didn't pass the check.

Co-authored-By: Hoang Trung Hieu <hieuht@vn.fujitsu.com>
Change-Id: I5a9299200202576d97760ebf07bceb930888f2d7
2018-01-19 08:20:56 +00:00

981 B
Raw Blame History

glance Style Commandments

glance Specific Commandments

  • [G316] Change assertTrue(isinstance(A, B)) by optimal assert like assertIsInstance(A, B)
  • [G317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B)
  • [G318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like assertIsNone(A)
  • [G319] Validate that debug level logs are not translated
  • [G320] For python 3 compatibility, use six.text_type() instead of unicode()
  • [G327] Prevent use of deprecated contextlib.nested
  • [G328] Must use a dict comprehension instead of a dict constructor with a sequence of key-value pairs
  • [G329] Python 3: Do not use xrange.
  • [G330] Python 3: do not use dict.iteritems.
  • [G331] Python 3: do not use dict.iterkeys.
  • [G332] Python 3: do not use dict.itervalues.