glance/HACKING.rst at e1b5d6d0b9740d2097e54b0af1cbb82fb5d58832

abhishekkekane e1b5d6d0b9 Hacking checks for not using dict iteration calls

Add hacking checks to check dict.iteritems, dict.itervalues
and dict.iterkeys should not be used in the future and
raise error while running pep8 using tox.

Trivial Fix

Change-Id: Id7f0c8b963cfd5739ed3e2ecec2c0feebc290af4

2016-01-25 21:54:08 -08:00

1.3 KiB

Raw Blame History

glance Style Commandments =======================

Step 1: Read the OpenStack Style Commandments http://docs.openstack.org/developer/hacking/
Step 2: Read on

glance Specific Commandments --------------------------

[G316] Change assertTrue(isinstance(A, B)) by optimal assert like assertIsInstance(A, B)
[G317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B)
[G318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like assertIsNone(A)
[G319] Validate that debug level logs are not translated
[G320] For python 3 compatibility, use six.text_type() instead of unicode()
[G321] Validate that LOG messages, except debug ones, have translations
[G322] Validate that LOG.info messages use _LI.
[G323] Validate that LOG.exception messages use _LE.
[G324] Validate that LOG.error messages use _LE.
[G325] Validate that LOG.critical messages use _LC.
[G326] Validate that LOG.warning messages use _LW.
[G327] Prevent use of deprecated contextlib.nested
[G328] Must use a dict comprehension instead of a dict constructor with a sequence of key-value pairs
[G329] Python 3: Do not use xrange.
[G330] Python 3: do not use dict.iteritems.
[G331] Python 3: do not use dict.iterkeys.
[G332] Python 3: do not use dict.itervalues.

1.3 KiB Raw Blame History

1.3 KiB

Raw Blame History