openstack/governance
Code Issues Proposed changes

Merge "tools: update check-review-status to drop grace period"

Browse Source
This commit is contained in:
Zuul
2020-06-22 12:33:24 +00:00
committed by Gerrit Code Review
parent d43187c157 79fd6a86f3
commit 44644653ad
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tools/check_review_status.py
View File

@@ -35,10 +35,6 @@ TC_SIZE = 11
# before it can be approved # before it can be approved
creation_age_threshold = datetime.timedelta(days=7) creation_age_threshold = datetime.timedelta(days=7)
# For formal-vote votes, age in days since a change has reached a
# the necessary amount of votes before it can be approved
reached_votes_age_threshold = datetime.timedelta(days=3)
def decode_json(raw): def decode_json(raw):
"""Trap JSON decoding failures and provide more detailed errors """Trap JSON decoding failures and provide more detailed errors
@@ -245,17 +241,10 @@ def get_one_status(change, delegates, tc_members):
creation_age_threshold.days) creation_age_threshold.days)
earliest = str(latest_created + creation_age_threshold) earliest = str(latest_created + creation_age_threshold)
elif reached_necessary_votes: elif reached_necessary_votes:
# Wait at least reached_votes_age_threshold days time_to_approve = True
# after reaching necessary votes.
earliest = str(
reached_necessary_votes + reached_votes_age_threshold
)
since_necessary_votes = now.date() - reached_necessary_votes.date()
time_to_approve = since_necessary_votes > reached_votes_age_threshold
else: else:
time_to_approve = False time_to_approve = False
earliest = "{} days after {} positive votes".format( earliest = "after {} positive votes".format(necessary_votes)
reached_votes_age_threshold.days, necessary_votes)
if votes_to_approve and time_to_approve: if votes_to_approve and time_to_approve:
parts.append('YES') parts.append('YES')