openstack/governance
Code Issues Proposed changes

Adapt tox tool based on latest changes

Browse Source 
The rules for the typo changes have been adapted, so we should
adapt the tooling to not be stricter than the rules.

Change-Id: Ibca617be5736da411bfc97a647fb805796ad09ef
This commit is contained in:
Jean-Philippe Evrard
2019-09-23 23:06:05 +02:00
parent 26ea5c2ff7
commit 46667f0158
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tools/check_review_status.py
View File

@@ -305,22 +305,11 @@ def get_one_status(change, delegates, tc_members):
can_approve = ',\n'.join(parts)
elif topic == 'typo-fix':
# https://governance.openstack.org/tc/reference/house-rules.html#typo-fixes
if votes[-1] or code_reviews[-1]:
can_approve = 'dissenting votes'
elif owner == 'Doug Hellmann' or owner == 'Mohammed Naser': # TC-chairs
if votes[1] < 2:
can_approve = 'not enough reviews'
else:
can_approve = 'YES, chair rules'
else:
can_approve = 'YES'
elif topic in ('code-change', 'documentation-change', 'election-results'):
elif topic in ('code-change', 'documentation-change', 'election-results', 'typo-fix'):
# https://governance.openstack.org/tc/reference/house-rules.html#code-changes
# https://governance.openstack.org/tc/reference/house-rules.html#documentation-changes
# https://governance.openstack.org/tc/reference/house-rules.html#election-results
# https://governance.openstack.org/tc/reference/house-rules.html#typo-fixes
if votes[-1] or code_reviews[-1]:
can_approve = 'dissenting votes'
elif votes[1] < 2: