openstack/hacking
Code Issues Proposed changes

Merge "Improve H202 to cover more cases"

Browse Source
This commit is contained in:
Jenkins 2013-09-02 06:08:30 +00:00 committed by Gerrit Code Review
commit 8d1ad3328a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hacking/core.py
View File

@ -281,8 +281,9 @@ def hacking_except_format_assert(logical_line):
Okay: self.assertRaises(NovaException, foo) Okay: self.assertRaises(NovaException, foo)
Okay: self.assertRaises(ExceptionStrangeNotation, foo) Okay: self.assertRaises(ExceptionStrangeNotation, foo)
H202: self.assertRaises(Exception, foo) H202: self.assertRaises(Exception, foo)
H202: self.assertRaises(Exception)
""" """
if logical_line.startswith("self.assertRaises(Exception,"): if re.match(r"self\.assertRaises\(Exception[,\)]", logical_line):
yield 1, "H202: assertRaises Exception too broad" yield 1, "H202: assertRaises Exception too broad"