916cbab38a
H6xx is reserved for calling methods (see http://docs.openstack.org/developer/hacking/#calling-methods), so move the three H6xx tests to more approrate locations. H601=>H903 H602=>H234 since the issue is that python3 gives an explicit warning H603=>H235 same reason as H234 Since only H601 has been released, this will have a minor impact Change-Id: Ie68c9b4421f615b6d76cfb400408c951fc335eeb
Introduction
hacking is a set of flake8 plugins that test and enforce the OpenStack Style Guidlines.
Origin
Most of the additional style guidelines that OpenStack has taken on came from the Google Python Style Guide.
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html
Since then, a few more OpenStack specific ones have been added or modified.
Versioning
hacking uses the major.minor.maintenance release notation, where maintenance releases cannot contain new checks. This way projects can gate on hacking by pinning on the major.minor number while accepting maintenance updates without being concerned that a new version will break the gate with a new check.
Adding additional checks
Each check is a pep8 plugin so read
https://github.com/jcrocholl/pep8/blob/master/docs/developer.rst#contribute
Requirements
- The check must already have community support. We do not want to dictate style, only enforce it.
- The canonical source of the OpenStack Style Guidelines is doc/source/index.rst, and hacking just enforces them; so when adding a new check, it must be in docs/source/index.rst
- False negatives are ok, but false positives are not
- Cannot be project specific, project specific checks should be Local Checks
- Docstring tests
- Registered as entry_points in setup.cfg
- Error code must be in the relevant
Hxxxgroup
Local Checks
hacking supports having local changes in a source tree. They can be configured to run in two different ways. They can be registered individually, or with a factory function.
For individual registration, put a comma separated list of pep8 compatible check functions into the hacking section of tox.ini. Like
[hacking] local-check = nova.tests.hacking.bad_code_is_terrible
Alternately, you can specify the location of a callable that will be called at registration time and will be passed the registration function. The callable should expect to call the passed in function on everything if wants to register. Such as:
[hacking] local-check-factory = nova.tests.hacking.factory