openstack/heat
Code Issues Proposed changes

Fix Firewall policy resource

Browse Source 
OS::Neutron::FirewallPolicy resource cannot be created without firewall_rules.
I can create firewall policy via the rest api of neutron.And in the rest api
of neutron to create firewall policy ,the firewall_rules is an optional parameter.
This should be consistent with the rest api of neutron.
So I think the firewall_rules should be an optional property
of OS::Neutron::FirewallPolicy resource.

Add releasenote about this.

Change-Id: I74cb22a7995376c2339f24fca9ca5d651d598480
Task: 36037
This commit is contained in:
lidong 2019-08-01 17:01:39 +08:00 committed by Zane Bitter
parent 70d7a1bc86
commit 624be98be0
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
heat/engine/resources/openstack/neutron/firewall.py
View File

@ -243,8 +243,8 @@ class FirewallPolicy(neutron.NeutronResource):
),
FIREWALL_RULES: properties.Schema(
properties.Schema.LIST,
_('An ordered list of firewall rules to apply to the firewall.'),
required=True,
_('An ordered list of firewall rules to apply to the firewall. '
'(Prior to version 14.0.0 this was a required property).'),
update_allowed=True
),
}

5
releasenotes/notes/update-firwallpolicy-ruls-90a8904e899b2365.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
The `firewall_rules` property of the `OS::Neutron::FirewallPolicy`
resource type is now optional.