openstack/heat
Code Issues Proposed changes

Enable E265 style check

Browse Source 
block comment should start with '# '

Change-Id: Iffae1b10e81b12ca8455139eae609ddca5e8dd09
This commit is contained in:
Pavlo Shchelokovskyy 2014-12-14 20:26:38 +02:00
parent 8f801e29c8
commit 8415baf6cc
32 changed files with 97 additions and 98 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
heat/db/sqlalchemy/migrate_repo/versions/018_resource_id_uuid.py
View File

@ -33,5 +33,5 @@ def downgrade(migrate_engine):
try: try:
resource.c.id.alter(sqlalchemy.Integer, primary_key=True) resource.c.id.alter(sqlalchemy.Integer, primary_key=True)
except Exception: except Exception:
#XXX: since there is no way to downgrade just passing # NOTE(sshturm): since there is no way to downgrade just passing
pass pass

8
heat/db/sqlalchemy/migrate_repo/versions/035_event_uuid_to_id.py
View File

@ -101,8 +101,8 @@ def upgrade_sqlite(migrate_engine):
# (pafuent) Here it isn't recommended to import the table from the models, # (pafuent) Here it isn't recommended to import the table from the models,
# because in future migrations the model could change and this migration # because in future migrations the model could change and this migration
# could fail. # could fail.
#I know it is ugly but it's the only way that I found to 'freeze' the model # I know it is ugly but it's the only way that I found to 'freeze'
#state for this migration. # the model state for this migration.
stack_table = sqlalchemy.Table('stack', meta, autoload=True) stack_table = sqlalchemy.Table('stack', meta, autoload=True)
event_table = sqlalchemy.Table( event_table = sqlalchemy.Table(
'new_event', meta, 'new_event', meta,
@ -196,8 +196,8 @@ def downgrade_sqlite(migrate_engine):
# (pafuent) Here it isn't recommended to import the table from the models, # (pafuent) Here it isn't recommended to import the table from the models,
# because in future migrations the model could change and this migration # because in future migrations the model could change and this migration
# could fail. # could fail.
#I know it is ugly but it's the only way that I found to 'freeze' the model # I know it is ugly but it's the only way that I found to 'freeze'
#state for this migration. # the model state for this migration.
stack_table = sqlalchemy.Table('stack', meta, autoload=True) stack_table = sqlalchemy.Table('stack', meta, autoload=True)
event_table = sqlalchemy.Table( event_table = sqlalchemy.Table(
'new_event', meta, 'new_event', meta,

3
tox.ini
View File

@ -54,7 +54,6 @@ commands =
[flake8] [flake8]
# E251 unexpected spaces around keyword / parameter equals # E251 unexpected spaces around keyword / parameter equals
# E265 block comment should start with '# '
# F402 import shadowed by loop variable # F402 import shadowed by loop variable
# F812 list comprehension redefines variable # F812 list comprehension redefines variable
# H202 assertRaises Exception too broad # H202 assertRaises Exception too broad
@ -66,7 +65,7 @@ commands =
# H405 multi line docstring summary not separated with an empty line # H405 multi line docstring summary not separated with an empty line
# H803 no full stop at the end of the commit message # H803 no full stop at the end of the commit message
# H904 Wrap long lines in parentheses instead of a backslash # H904 Wrap long lines in parentheses instead of a backslash
ignore = E251,E265,F402,F812,H202,H233,H305,H307,H402,H404,H405,H803,H904 ignore = E251,F402,F812,H202,H233,H305,H307,H402,H404,H405,H803,H904
show-source = true show-source = true
exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,tools,build exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,tools,build
max-complexity=20 max-complexity=20