openstack
/
heat
Code Issues Proposed changes

Remove useless validate methods 

Remove the validate methods of s3 and swift resources, as they don't
provide any value and hide validation of properties.

Change-Id: I5b9f7aef828d5e4d7cdebfd2bd550feaae545c90
Closes-Bug: #1260643
This commit is contained in:
Thomas Herve 2013-12-16 16:05:44 +01:00
parent 0ceb85dda3
commit f204ad21ec
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
heat/engine/resources/s3.py
View File

@ -100,15 +100,6 @@ class S3Bucket(resource.Resource):
'WebsiteURL': _('The website endpoint for the specified bucket.')
}
def validate(self):
'''
Validate any of the provided params
'''
#check if swiftclient is installed
if clients.swiftclient is None:
return {'Error':
'S3 services unavailable because of missing swiftclient.'}
def tags_to_headers(self):
if self.properties[self.TAGS] is None:
return {}

9
heat/engine/resources/swift.py
View File

@ -66,15 +66,6 @@ class SwiftContainer(resource.Resource):
'HeadContainer': _('A map containing all headers for the container.')
}
def validate(self):
'''
Validate any of the provided params
'''
#check if swiftclient is installed
if clients.swiftclient is None:
return {'Error':
'SwiftContainer unavailable due to missing swiftclient.'}
def physical_resource_name(self):
name = self.properties.get(self.NAME)
if name: