11911 Commits

Author SHA1 Message Date
Sampat P
762879a145 [S2007220]: Added more image properties to web_image
Story: 2007220
Task: 38472

Change-Id: I9980fee0b33c45e6d80862ca4a43abf075a4dd58
2020-11-17 05:14:58 +00:00
Zuul
607d73ea6f Merge "Remove handling for client status races" 2020-11-16 09:20:26 +00:00
David Hill
b068f45add As of nova microversion 2.57, personality is deprecated
This patch returns a stack validation error if the nova microversion
is 2.57 or greater and the personality parameter is also specified
in the templates.

Change-Id: I0919150baa36112ccbd8bfd7ccebc7aab5735cf3
Task: 41229
2020-11-09 07:38:33 -05:00
Zuul
3b05f784a8 Merge "Add SOURCE_IP_PORT to LB_ALGORITHM allowed values" 2020-11-06 09:04:38 +00:00
Kevin Carter
20b599cdf8 Add SOURCE_IP_PORT to LB_ALGORITHM allowed values
This change adds SOURCE_IP_PORT to lb_algorithm property of
OS::Octavia::Pool resource which is missing from the available options
and required when using the OVN provider driver.

[0] https://docs.openstack.org/ovn-octavia-provider/latest/admin/driver.html#limitations-of-the-ovn-provider-driver
[1] https://docs.openstack.org/releasenotes/octavia/train.html

Change-Id: Ibed37eea817a5125c5751b2bc9f44acf3c016fe1
Signed-off-by: Kevin Carter <kecarter@redhat.com>
2020-11-06 03:51:13 +00:00
Zuul
2d85fdd51a Merge "Delete the default value of domain in role creation" 2020-11-04 19:30:44 +00:00
Zuul
3e2209aeb8 Merge "Use set instead of list of server_deferred_statuses" 2020-11-03 00:10:50 +00:00
Zuul
5eec3e4bd0 Merge "Modify 'if' Macro to allow optional properties" 2020-11-02 17:46:26 +00:00
Zuul
cba6d9b03a Merge "Add template version 2021-04-16 for Wallaby" 2020-11-02 17:45:07 +00:00
Zuul
2b43c9e8f2 Merge "Allow null values to be returned from Macros" 2020-11-02 17:39:38 +00:00
Zuul
369d77f195 Merge "Refactor Properties._get_property_value()" 2020-11-02 10:00:02 +00:00
yanpuqing
e5b00ddfaf Delete the default value of domain in role creation
The default value of domain caused the user to be unable to create
role which no domain.
The patch delete the default value of domain.

Change-Id: Ic67b22c435e29f67bafa8e14ab502ebec5b07ec5
Story: 2002671
Task: 22488
2020-11-02 08:07:34 +00:00
Zane Bitter
71a9c3d690 Modify 'if' Macro to allow optional properties
Change-Id: I931d88e79fc077d12fc9bd39009061ffe87f1262
Story: 2007388
Task: 38973
2020-10-27 16:59:30 -04:00
Zane Bitter
674a62ae9b Add template version 2021-04-16 for Wallaby
Change-Id: I57047682cfa82ba6ca4affff54fab5216e9ba51c
Story: 2007388
2020-10-27 16:55:38 -04:00
OpenStack Proposal Bot
f0d7425dbb Imported Translations from Zanata
For more information about this automatic import see:
https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

Change-Id: Ie586d26a78e29d82b3cc3279006e27e754f003b3
2020-10-11 06:33:28 +00:00
Tim Burke
a78ddafdec Use err.errno to access errno for socket errors
Otherwise, you may see errors like

    TypeError: 'OSError' object is not subscriptable

Change-Id: I2aa952d6e323f2f30ab915c3fbf609c651ed1fe9
2020-09-26 21:33:03 -07:00
Zuul
8250a83978 Merge "Net attr: Sort segments without name attribute first" 2020-09-21 19:07:45 +00:00
Zuul
8e1e3d6011 Merge "Set context username if session client is used" 2020-09-20 10:02:46 +00:00
Harald Jensås
539b2a4c49 Net attr: Sort segments without name attribute first
Useing get_attr, pulling index 0 in the segments list
of a network to associate the a subnet with the "first"
segment is useful since the "first" segment is created
by neutron behind the scenes on network create. A resource
reference cannot be used since the "first" segment is'nt
a heat resource.

The issue is the order of the segments list is'nt reliable.

On stack update index 0 may be a different segment, and
we end up trying to update the segment_id for a subnet.
Changeing the segment association is not allowed, so
the stack update fails.

While not perfect, sorting the list so that segments where
name is None comes first will ensure that index 0 can be used.

The template author should ensure segments defined in the heat
template all have a names set, so that only the segment creted
implicitly by neutron have 'None' name.

Closes-Bug: #1894920
Change-Id: I097aba2a97144327bec188e6c71629d0f6c95901
2020-09-18 14:03:33 +00:00
Zuul
c54518d607 Merge "Lazily cache parsed value of list/json parameters" 2020-09-01 10:26:28 +00:00
Zane Bitter
b603470a12 Lazily cache parsed value of list/json parameters
Parsing the value of JSON parameters at the time we create them (or
update the default value) results in exceptions occurring while creating
the Stack object, that are then not caught and transformed. The result
is an HTTP 500 Internal Error reported by the API, with an unhelpful
error message.

By not parsing the JSON until it is needed, we ensure that any errors
will occur during validation, where errors are appropriately transformed
(to StackValidationFailed) and annotated with the necessary information
to help the user determine the source.

Depends-On: https://review.opendev.org/#/c/748359/

Change-Id: I70e341c344d6254173ad4519276626230087263a
Story: 2007957
Task: 40443
2020-08-28 03:54:19 +00:00
Zuul
b18aadc84d Merge "Bump MANILACLIENT_VERSION and use sharev2 endpoint" 2020-08-25 20:53:45 +00:00
Jan Horstmann
f98aef09e2 Bump MANILACLIENT_VERSION and use sharev2 endpoint
This commit bumps MANILACLIENT_VERSION to 2.13 and changes the used
service type to sharev2.

In order to support the value of "cephx" in property
'{"access_rules": [{"access_type": ""}]}' in ressource
OS::Manila::Share, manilaclient needs to use at least version 2.13 of
the manila API ([1]). The default minimum version in manilaclient, which
is used when only a mayor version is specified is 2.0.
Additionally the sharev2 service type endpoint has to be used to access
the manila v2 API.

The export_locations response was removed in version 2.9 of manila API
from the "Show share details" request ([2]) and moved to its own
endpoint in [3]. Thus it is requested from there now.
Additionally the new endpoint is more verbose, so only its path
attribute is returned, in order to match the previous behaviour.

[1]
https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html
[2]
https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-single-export-location-detail,show-share-details-detail#show-share-details
[3]
https://docs.openstack.org/api-ref/shared-file-system/?expanded=show-single-export-location-detail,list-export-locations-detail#list-export-locations

Change-Id: I4c37be8fad1edb05d812fed260e97e9188fd23ce
Story: 2007986
Task: 40612
2020-08-25 16:20:53 +02:00
Zuul
0b01294612 Merge "Assigning resource_id to resource OS::Cinder::QoSAssociation" 2020-08-24 20:22:47 +00:00
Zuul
7c616e95fc Merge "Correct release version for OS::Neutron::ProviderNet dns_domain" 2020-08-19 07:58:16 +00:00
Zuul
9b7bc30a7d Merge "Add 'smart-nic' vnic type support for OS::Neutron::Port" 2020-08-17 17:40:46 +00:00
Zuul
4d7fc11152 Merge "Fix OS::Heat::Delay resource type" 2020-08-17 05:27:32 +00:00
Zuul
d4460bbecc Merge "Supports 'virtio-forwarder' vnic type for port" 2020-08-15 08:05:12 +00:00
Zane Bitter
c362c57854 Fix OS::Heat::Delay resource type
Don't override ResourceStatus.ACTIONS, as it's used internally by the
Resource class.

Change-Id: Icf306e981c19e3d5410905befa7907dcdba33337
Story: 2008013
Task: 40663
2020-08-13 11:39:17 -04:00
Rabi Mishra
56a663c2d9 Add 'smart-nic' vnic type support for OS::Neutron::Port
I91f63810626ce4e054e358f5de5e46434c4da131 added it in neutron.

Task: 40436
Depends-On: https://review.opendev.org/746034
Change-Id: If04e080d2e399795d501d0317196589dcbd934e5
2020-08-13 09:31:17 +00:00
Zane Bitter
c680d8933d Correct release version for OS::Neutron::ProviderNet dns_domain
The patch adding this new property was approved during the Ussuri
release cycle, but only merged in the Victoria release. Therefore the
version in the SupportStatus should be 15.0.0, not 14.0.0.

Change-Id: I1e825834049f47a470280cce6c8bd89ef7e9ae61
2020-08-12 10:06:35 -04:00
Zuul
65de8cb436 Merge "Eliminate Master/Slave terminology from Designate Zone resource" 2020-07-24 15:52:10 +00:00
Arun Vinod
cd030d859f Assigning resource_id to resource OS::Cinder::QoSAssociation
Without this, the QoSAssociation resource is being created without a
resource_id. This raises an Exception while peforming stack_adopt on
such resources, since adopt requires resource_id for all resources.

The proposed approach is to set uuid to QoSAssociation as well.


Change-Id: Ic4c50b36d40592e1159827376ef78eaa86c31b53
Task: #39994
Story: #39994
2020-07-24 09:30:10 +00:00
Emilien Macchi
03ab18d459 Supports 'virtio-forwarder' vnic type for port
Supports the 'virtio-forwarder' vnic type for port sync with Neutron.
The 'virtio-forwarder' is an indirect mode for SR-IOV interfaces used to
connect the instances into the Neutron networks. It has been supported
since the Queens release:
I28315fb12f62dc7d52d099c211086b2b81eca39a

Note that 'virtio-forwarder' is already supported by Horizon:
openstack_dashboard/api/neutron.py:
  ('virtio-forwarder', _('Virtio Forwarder'))

Nova:
nova/network/model.py:
  VNIC_TYPE_VIRTIO_FORWARDER = 'virtio-forwarder'

openstackclient:
openstackclient/network/v2/port.py:
  choices=(...), virtio-forwarder

neutron-lib:
neutron_lib/api/definitions/portbindings.py
  VNIC_VIRTIO_FORWARDER = 'virtio-forwarder'

Task: 40435
Change-Id: Ie65f8858d6d1a1854702eb33c40ea827505bfe51
2020-07-24 13:34:35 +05:30
Zuul
836b9260a6 Merge "Rename variables in sort key validation" 2020-07-20 22:54:06 +00:00
Zuul
1fd6aa39d0 Merge "Improve naming of get_allowed_params() argument" 2020-07-20 22:24:42 +00:00
Zuul
0fdc2ae41c Merge "Use 'skiplist' to describe skipped indices in ResourceGroup code" 2020-07-20 17:34:34 +00:00
Zuul
cf2ed9cd9c Merge "Use correct attribute from entrypoint" 2020-07-16 06:34:37 +00:00
Rabi Mishra
2aea5c9b32 Use correct attribute from entrypoint
The type of the entry point objects returned in stevedore has
been changed from`pkg_resources.EntryPoint` to
`importlib.metadata.EntryPoint`[1] and it does not have module_name
attribute.

It also bumps requirements/lower-constraints as stevedore==3.1.0 is
not backward compatible.

[1] https://review.opendev.org/#/c/740515/
Task: 40355
Change-Id: Icd68f6eab73e44406f2ff5073636dcdd111e00ea
2020-07-15 17:51:57 +05:30
Zane Bitter
a3eeefb6d7 Eliminate Master/Slave terminology from Designate Zone resource
Change-Id: If136f5e270db5df1f871dc9473afb178e242bc18
2020-07-14 19:45:42 -04:00
Zane Bitter
2c28e6b978 Rename variables in sort key validation
Avoid unnecessarily divisive terms.

Change-Id: Ida9384c849cd664c5fc5d31449350d7cb6a68b78
2020-07-14 14:53:59 -04:00
Zane Bitter
73d05c0cdc Improve naming of get_allowed_params() argument
This used to be just a list of allowed names, but now it's a dict
mapping names to types. Use variable names that reflect the current
meaning, fix the docs, and use named constants where available.

Change-Id: I3aadca4e1e9db5da5d07d521c2313162062639b7
2020-07-14 14:53:59 -04:00
Zane Bitter
24bae944dc Use 'skiplist' to describe skipped indices in ResourceGroup code
Don't use needlessly divisive terminology.

Change-Id: I86a06cd2c5cebcc3d2cd07b675f626a917bb9db4
2020-07-14 14:53:59 -04:00
Andrii Ostapenko
402750b099 Set context username if session client is used
Now context username is set from X-Auth-User header, that is not set
with session client. This results in stack_owner attribute None for
newly created stacks.
This commit sets context username from auth token in case of absent
X-Auth-User header.

Affects all releases at least since Ocata.

Story: 2007856
Change-Id: I9cba3495fd472769498486d52d3909bff03010d4
2020-07-06 19:34:52 +00:00
Zuul
9f931119ba Merge "Deprecate wrappertask decorator" 2020-07-06 06:00:17 +00:00
Rabi Mishra
8d5d2a8fb6 Don't check stack staus for already migrated stacks
If stacks are already migrated to convergence, there is no point
in checking stack status before returning. This will allow re-run
of the command inspite of migrated stacks in FAILED state.

Change-Id: Ia0e34423377843adee8efc7f23d2c2df5dac8e20
Task: 40266
2020-07-02 10:43:00 +05:30
Zuul
c5a14a88cf Merge "Use unittest.mock instead of mock" 2020-07-01 05:18:10 +00:00
Rabi Mishra
01c230e793 Check for nova exception.Conflict rather than task_state
When detaching and attaching volumes nova would raise an
exception.Conflict, if attach and detach can't happen. Let's
use that to retry rather than using task_state.

Change-Id: I50904e4254568cd807b9ff18eef482cadb626ce5
Task: 40169
2020-06-26 14:29:54 +05:30
Hervé Beraud
eab4382df8 Use unittest.mock instead of mock
The mock third party library was needed for mock support in py2
runtimes. Since we now only support py36 and later, we can use the
standard lib unittest.mock module instead.

Change-Id: Ie0e43904d375e542ca00cd43b3c84c7afb31ee85
2020-06-10 13:50:56 +02:00
Rabi Mishra
d0e44ded0a Use never expiring alarm_url for resource attributes
Don't use timestamp when generating ec2 signed url for alarm url
attributes of resource.

This will resolve the issue for new resources even if they are cached
in attributes or resource_data.

However, for existing stacks containing these resources the current
best option is to not cache these attributes and allow alarm resources
to be able to get a new never expiring urls in the next forced update.

Change-Id: If2ebc3deacb770294004ae023500367af603b59e
Task: 39985
Related-Bug: #1872737
2020-06-06 14:02:09 +05:30