Remove #noqa from two common imports and add them to import_exceptions

We have two imports with #noqa: django.conf.urls.patterns and
django.conf.urls.url however using them is a standard way of creating
any urls.py module. So there are over 150 imports in Horizon code
where #noqa could be replaced with two lines in list of import_exceptions.

Change-Id: I81c3290e0dc958b5037dd6a87e44df18adfbe751
This commit is contained in:
Tatiana Ovchinnikova 2014-09-16 14:07:57 +04:00
parent 92ee627815
commit 539c14e1c6
77 changed files with 155 additions and 151 deletions

View File

@ -8,6 +8,8 @@ Horizon Style Commandments
collections.defaultdict,
django.conf.settings,
django.conf.urls.patterns,
django.conf.urls.url,
django.core.urlresolvers.reverse,
django.core.urlresolvers.reverse_lazy,
django.template.loader.render_to_string,

View File

@ -396,8 +396,8 @@ URLs
----
The auto-generated ``urls.py`` file is like::
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from .views import IndexView
@ -428,8 +428,8 @@ Notice that ``mypanel_tabs`` is the ``slug`` attribute defined in the
The completed ``urls.py`` file should look like the following::
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.mydashboard.mypanel import views

View File

@ -28,8 +28,8 @@ import os
from django.conf import settings
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from django.core.exceptions import ImproperlyConfigured # noqa
from django.core.urlresolvers import reverse
from django.utils.datastructures import SortedDict

View File

@ -1,5 +1,5 @@
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from .views import IndexView

View File

@ -18,8 +18,8 @@
from django.conf import settings
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from django.views.generic import TemplateView # noqa
from horizon.test.jasmine import jasmine

View File

@ -1,5 +1,5 @@
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from horizon.test.test_dashboards.cats.kittens.views import IndexView # noqa

View File

@ -1,5 +1,5 @@
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from horizon.test.test_dashboards.cats.tigers.views import IndexView # noqa

View File

@ -1,5 +1,5 @@
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from horizon.test.test_dashboards.dogs.puppies.views import IndexView # noqa
from horizon.test.test_dashboards.dogs.puppies.views import TwoTabsView # noqa

View File

@ -21,8 +21,8 @@ URL patterns for testing Horizon views.
"""
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from django.contrib.staticfiles.urls import staticfiles_urlpatterns # noqa
from django.views.generic import TemplateView # noqa

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.aggregates \
import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.flavors import views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.hypervisors.compute import views

View File

@ -13,8 +13,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.hypervisors.compute \
import urls as compute_urls

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.images import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.info import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.instances import views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.metering import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.networks.ports import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.networks.subnets import views

View File

@ -13,8 +13,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.networks.agents \
import views as agent_views

View File

@ -17,8 +17,8 @@
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.overview import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.routers.ports import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.routers import views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.volumes.snapshots import views

View File

@ -11,8 +11,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.volumes.snapshots \
import urls as snapshot_urls

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.volumes.volume_types.extras \
import views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.volumes.volume_types.qos_specs \
import views

View File

@ -11,8 +11,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.volumes.volume_types.extras \
import urls as extras_urls

View File

@ -11,8 +11,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.admin.volumes.volumes \
import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.identity.domains import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.identity.groups import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.identity.projects import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.identity.roles import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.identity.users import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.access_and_security.\
api_access import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.access_and_security.\
floating_ips import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.access_and_security.keypairs \
import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.access_and_security.\
security_groups import views

View File

@ -17,8 +17,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.access_and_security.\
api_access import urls as api_access_urls

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.containers import views

View File

@ -11,8 +11,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project. \
data_processing.cluster_templates.views as views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project.data_processing. \
clusters.views as views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project. \
data_processing.data_image_registry.views as views

View File

@ -11,8 +11,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.\
data_processing.data_plugins import views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project.data_processing. \
data_sources.views as views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project.data_processing. \
job_binaries.views as views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project.data_processing. \
job_executions.views as views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project.data_processing. \
jobs.views as views

View File

@ -12,8 +12,8 @@
# limitations under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
import openstack_dashboard.dashboards.project. \
data_processing.nodegroup_templates.views as views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.database_backups import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.databases import views

View File

@ -14,8 +14,8 @@
#
# @author: KC Wang, Big Switch Networks
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.firewalls import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.images.images import views

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.images.snapshots import views

View File

@ -17,8 +17,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.images.images \
import urls as image_urls

View File

@ -16,8 +16,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.instances import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.loadbalancers import views

View File

@ -17,8 +17,8 @@
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.network_topology import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.networks.ports import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.networks.subnets import views

View File

@ -13,8 +13,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.networks.ports \
import urls as port_urls

View File

@ -17,8 +17,8 @@
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.overview import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.routers.ports import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.routers.extensions.routerrules\
import views as rr_views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.stacks import views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.volumes.backups import views

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.volumes.snapshots import views

View File

@ -13,8 +13,8 @@
# under the License.
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.volumes.backups \
import urls as backups_urls

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.volumes \
.volumes import views

View File

@ -14,8 +14,8 @@
#
# @author: Tatiana Mazur
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.project.vpn import views

View File

@ -13,8 +13,8 @@
# @author: Abishek Subramanian, Cisco Systems, Inc.
# @author: Sergey Sudakovich, Cisco Systems, Inc.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.router.nexus1000v import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.settings.password import views

View File

@ -12,8 +12,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.dashboards.settings.user import views

View File

@ -1,4 +1,4 @@
from django.conf.urls import patterns # noqa
from django.conf.urls import patterns
from openstack_dashboard.urls import urlpatterns # noqa

View File

@ -10,8 +10,8 @@
# License for the specific language governing permissions and limitations
# under the License.
from django.conf.urls import patterns # noqa
from django.conf.urls import url # noqa
from django.conf.urls import patterns
from django.conf.urls import url
from openstack_dashboard.test.test_panels.plugin_panel import views

View File

@ -22,9 +22,9 @@ URL patterns for the OpenStack Dashboard.
from django.conf import settings
from django.conf.urls import include # noqa
from django.conf.urls import patterns # noqa
from django.conf.urls import patterns
from django.conf.urls.static import static # noqa
from django.conf.urls import url # noqa
from django.conf.urls import url
from django.contrib.staticfiles.urls import staticfiles_urlpatterns # noqa
import horizon

View File

@ -71,6 +71,8 @@ ignore = E127,E128,H307,H405,H803,H904
[hacking]
import_exceptions = collections.defaultdict,
django.conf.settings,
django.conf.urls.patterns,
django.conf.urls.url,
django.core.urlresolvers.reverse,
django.core.urlresolvers.reverse_lazy,
django.template.loader.render_to_string,