openstack/horizon
Code Issues Proposed changes

Replace DOMNodeInserted events with a mutation observer

Browse Source 
The DOMNodeInserted events are deprecated in modern browsers, and will
shortly stop working. We should be using mutation observers instead.

This change gets rids of deprecation warnings in the js console.

Signed-off-by: Radomir Dopieralski <openstack@dopieralski.pl>
Change-Id: I355d3217b0f461f043248a1a2be47daccc6b2842
This commit is contained in:
Radomir Dopieralski
2025-10-06 09:59:22 +02:00
parent fc2de23a1b
commit 64d34854bc
1 changed files with 24 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
horizon/static/horizon/js/horizon.forms.js
View File

@@ -354,13 +354,20 @@ horizon.forms.init_themable_select = function ($elem) {
};
horizon.forms.init_new_selects = function () {
$(document).on('DOMNodeInserted', function(e) {
var $target = $(e.target);
var newInputs = $target.find('.themable-select').not('.select-initialized');
for (var ii = 0; ii < newInputs.length; ii++) {
horizon.forms.init_themable_select($(newInputs[ii]));
var observer = new MutationObserver(function (mutations) {
for (var mutation in mutations) {
if (mutation.type !== 'childList') {
continue;
}
for (var node in mutation.addedNodes) {
var newInputs = $(node).find('.themable-select').not('.select-initialized');
for (var input in newInputs) {
horizon.forms.init_themable_select($(input));
}
}
}
});
observer.observe(document, { childList: true, subtree: true });
};
horizon.forms.getSpinnerValue = function(val, defaultVal) {
@@ -446,13 +453,20 @@ horizon.forms.init_themable_spinner = function ($elem) {
};
horizon.forms.init_new_spinners = function () {
$(document).on('DOMNodeInserted', function(e) {
var $target = $(e.target);
var newInputs = $target.find('.themable-spinner').not('.spinner-initialized');
for (var ii = 0; ii < newInputs.length; ii++) {
horizon.forms.init_themable_spinner($(newInputs[ii]));
var observer = new MutationObserver(function (mutations) {
for (var mutation in mutations) {
if (mutation.type !== 'childList') {
continue;
}
for (var node in mutation.addedNodes) {
var newSpinners = $(node).find('.themable-spinner').not('.spinner-initialized');
for (var spinner in newSpinners) {
horizon.forms.init_themable_spinner($(spinner));
}
}
}
});
observer.observe(document, { childList: true, subtree: true });
};
horizon.addInitFunction(horizon.forms.init = function () {