openstack/horizon
Code Issues Proposed changes

integration tests: Relax router interface status check

Browse Source 
Previously the router interface test in the integration tests
checked the status of an added router interface, but the initial
status varies depending on a network backend used in neutron.
In case of neutron L3 agent, a new router interface has "Down" status,
but in case of OVN a new router interface has "Active" status.
This caused the integration test failure after DevStack switched
the default network backend from ML2/OVS to ML2/OVN.

The initial status of a new router interface depends on a network
backend and the neutron API does not define the initial status,
so it is too strict for the horizon integration tests to check
the status. This commit drops the status check.
It is sufficient to check the existence of a new router interface.

Change-Id: Idfd4a9206e85558ba17e476a47b38ee9c1f566fa
Closes-Bug: #1930405
This commit is contained in:
Akihiro Motoki 2021-06-04 16:18:56 +09:00
parent ebec26abe9
commit 866a170379
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstack_dashboard/test/integration_tests/tests/test_router.py
View File

@ -61,8 +61,6 @@ class TestRouters(helpers.TestCase):
interfaces_page.find_message_and_dismiss(messages.ERROR)) interfaces_page.find_message_and_dismiss(messages.ERROR))
interface_name = interfaces_page.interface_name interface_name = interfaces_page.interface_name
self.assertTrue(interfaces_page.is_interface_present(interface_name)) self.assertTrue(interfaces_page.is_interface_present(interface_name))
self.assertTrue(
interfaces_page.is_interface_status(interface_name, 'Down'))
def _delete_interface(self, interfaces_page, interface_name): def _delete_interface(self, interfaces_page, interface_name):
interfaces_page.delete_interface(interface_name) interfaces_page.delete_interface(interface_name)