openstack/horizon
Code Issues Proposed changes

Remove the check which causes plugin's quotas update failure

Browse Source 
The check causes external plugin's quotas fields unknown
exception because the quotas fields are not part of
QUOTA_FIELDS which only includes the fields for
cinder, neutron and nova.

Meanwhile the exception message throws TypeError.

This commit removes the uncessary check. It also helps
fix the manila-ui's bug #1842119

Change-Id: If093f4ecf1e344792b347c5c338b441b1ab42a04
Closes-bug: #1798048
Closes-bug: #1842119
(cherry picked from commit 44987f02be)
(cherry picked from commit be4d2301bb)
This commit is contained in:
Gloria Gu 2019-08-30 13:47:39 -07:00 committed by Keith Berger
parent 7ad3cf215f
commit 93c4ded713
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstack_dashboard/usage/quotas.py
View File

@ -238,9 +238,6 @@ def get_tenant_quota_data(request, disabled_quotas=None, tenant_id=None):
@profiler.trace
def get_disabled_quotas(request, targets=None):
if targets:
if set(targets) - QUOTA_FIELDS:
raise ValueError('Unknown quota field names are included: %s'
% set(targets) - QUOTA_FIELDS)
candidates = set(targets)
else:
candidates = QUOTA_FIELDS