openstack/horizon
Code Issues Proposed changes

pylint: fix raising-non-exception error

Browse Source 
django.http.HttpResponseNotFound is not an exception.
Django recommends to return it. @rest_utils.ajax can handle it.

Change-Id: I26f82da022a2c2725d62cc136c5da8eafc0ac26f
This commit is contained in:
Akihiro Motoki 2018-12-10 04:07:01 +09:00
parent 136a3e1dea
commit a984ae43e5
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.pylintrc
View File

@ -13,7 +13,6 @@ disable=
method-hidden,
no-member,
not-callable,
raising-non-exception,
# "W" Warnings for stylistic problems or minor programming issues
arguments-differ,
attribute-defined-outside-init,

6
openstack_dashboard/api/rest/keystone.py
View File

@ -135,7 +135,7 @@ class User(generic.View):
This method returns HTTP 204 (no content) on success.
"""
if id == 'current':
raise django.http.HttpResponseNotFound('current')
return django.http.HttpResponseNotFound('current')
api.keystone.user_delete(request, id)
@rest_utils.ajax(data_required=True)
@ -255,7 +255,7 @@ class Role(generic.View):
This method returns HTTP 204 (no content) on success.
"""
if id == 'default':
raise django.http.HttpResponseNotFound('default')
return django.http.HttpResponseNotFound('default')
api.keystone.role_delete(request, id)
@rest_utils.ajax(data_required=True)
@ -355,7 +355,7 @@ class Domain(generic.View):
This method returns HTTP 204 (no content) on success.
"""
if id == 'default':
raise django.http.HttpResponseNotFound('default')
return django.http.HttpResponseNotFound('default')
api.keystone.domain_delete(request, id)
@rest_utils.ajax(data_required=True)