openstack
/
horizon
Code Issues Proposed changes

Fix Horizon to work with the latest pyScss 

pyScss v1.3.5 implements 'function-exists' function now. It breaks
MaterialDesign-Webfont [1] which is provided by xstatic-mdi package.

This patch re-implements FontAwesome-based styles for Material theme to
not use MaterialDesign-Webfont classes.

Another advantage of this improvement is we can use the latest pyScss
(once it'll be released) and update xstatic-mdi too.

[1] https://github.com/Templarian/MaterialDesign-Webfont/issues/19

Closes-Bug: #1771559
Depends-On: https://review.opendev.org/714450
Change-Id: Ia9e1e807591d4428f585177f521d4cb9d463b917
This commit is contained in:
Ivan Kolodyazhny 2020-03-21 19:17:31 +02:00 committed by Akihiro Motoki
parent 7f26bfcbb1
commit ddc52a7405
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lower-constraints.txt
View File

@ -20,7 +20,7 @@ Django==2.2
django-appconf==1.0.2
django-compressor==2.0
django-debreach==1.4.2
django-pyscss2==3.0.0
django-pyscss==2.0.2
docutils==0.11
dogpile.cache==0.6.2
dulwich==0.15.0
@ -89,7 +89,7 @@ pymongo==3.0.2
pyOpenSSL==17.1.0
pyparsing==2.1.0
pyperclip==1.5.27
pyScss2==1.4.0
pyScss==1.3.6
python-cinderclient==5.0.0
python-dateutil==2.5.3
python-glanceclient==2.8.0

4
openstack_dashboard/themes/material/static/horizon/_icons.scss
View File

@ -86,6 +86,8 @@ $icon-swap: (
@each $fa-icon, $mdi-icon in $icon-swap {
.fa-#{$fa-icon} {
@extend .mdi-#{$mdi-icon};
&:before {
content: unquote("\"\\#{map-get($mdi-icons, $mdi-icon)}\"");
}
}
}

4
requirements.txt
View File

@ -15,7 +15,7 @@ debtcollector>=1.2.0 # Apache-2.0
Django>=2.2,<3.0 # BSD
django-compressor>=2.0 # MIT
django-debreach>=1.4.2 # BSD License (2 clause)
django-pyscss2>=3.0.0 # BSD License (2 clause)
django-pyscss>=2.0.2 # BSD License (2 clause)
futurist>=1.2.0 # Apache-2.0
iso8601>=0.1.11 # MIT
keystoneauth1>=3.4.0 # Apache-2.0
@ -29,7 +29,7 @@ oslo.upgradecheck>=0.1.1 # Apache-2.0
oslo.utils>=3.33.0 # Apache-2.0
osprofiler>=2.3.0 # Apache-2.0
pymongo!=3.1,>=3.0.2 # Apache-2.0
pyScss2>=1.4.0 # MIT License
pyScss>=1.3.6 # MIT License
python-cinderclient>=5.0.0 # Apache-2.0
python-glanceclient>=2.8.0 # Apache-2.0
python-keystoneclient>=3.22.0 # Apache-2.0