openstack
/
horizon
Code Issues Proposed changes

Use TOX_CONSTRAINTS_FILE 

UPPER_CONSTRAINTS_FILE is old name and deprecated
This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.
For more info. please refer [1].

[1] https://zuul-ci.org/docs/zuul-jobs/python-roles.html#rolevar-tox.tox_constraints_file

Change-Id: I1600df016b90383c77e179e186d8c58fa9868d92
This commit is contained in:
zhangboye 2020-12-24 13:49:41 +08:00 committed by manchandavishal
parent d9d54b1fff
commit f0460fc437
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/contributor/topics/code-style.rst
View File

@ -338,7 +338,7 @@ Having done a release of an xstatic package:
"include-pypi-link: yes" setting. "include-pypi-link: yes" setting.
2. Pull that patch down so you have the edited upper-constraints.txt file 2. Pull that patch down so you have the edited upper-constraints.txt file
locally. locally.
3. Set the environment variable `UPPER_CONSTRAINTS_FILE` to the edited 3. Set the environment variable `TOX_CONSTRAINTS_FILE` to the edited
upper-constraints.txt file name and run tests or local development server upper-constraints.txt file name and run tests or local development server
through tox. This will pull in the precise version of the xstatic package through tox. This will pull in the precise version of the xstatic package
that you need. that you need.

4
tox.ini
View File

@ -20,7 +20,7 @@ whitelist_externals =
bash bash
find find
deps = deps =
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/test-requirements.txt -r{toxinidir}/test-requirements.txt
-r{toxinidir}/requirements.txt -r{toxinidir}/requirements.txt
commands = commands =
@ -123,7 +123,7 @@ commands =
[testenv:docs] [testenv:docs]
# We need to install horizon dependecies to build module references # We need to install horizon dependecies to build module references
deps = deps =
-c{env:UPPER_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master} -c{env:TOX_CONSTRAINTS_FILE:https://releases.openstack.org/constraints/upper/master}
-r{toxinidir}/requirements.txt -r{toxinidir}/requirements.txt
-r{toxinidir}/doc/requirements.txt -r{toxinidir}/doc/requirements.txt
commands = commands =