Since _cls_registry is now a list, removing a non-existing
element throws a ValueError instead of a KeyError.
This did not result in the desired NotRegistered exception.
Change-Id: I2ae7381ce65a0c8fa7deed2c08bfc51e1685f09e
Closes-Bug: 1776187
This commit adds cinder generic group support.
Consistency group support are not shown if the generic group
support is available.
blueprint cinder-generic-volume-groups
Change-Id: I038eeaf2508926f18b6053db0082a8aa3f3e20c6
This patch leave selenuim-headless non-voting since it was broken for a
while so we should be sure that it's stable enough.
Related blueprint: improve-horizon-testing
Change-Id: Ic2a877a4eefc2f10fb25e64c387b81fc18302a2a
Nose has been in maintenance mode for the past several years. It has
issue with exit code [1] which leads to false positive results for our
seleniun-headless job.
This patch changes test runner for Horizon tests and does the following
things:
* Django test runner executes test in a different order than Nose does.
That's why we've got an issue with side-effect in
horizon.tests.unit.tables.test_tables.MyToggleAction class. This patch
adds workaround to it.
* Rename filename of test files to names starting with 'test_'
so that the django test runner can find tests expectedly.
* '--with-html-output' option is temporary dropped and will be added in
a following patch.
* Integraion tests is marked via django.test.tag mechanism which is
introduced in Django 1.10
* 'selenium-headless' is broken now because we don't have geckodriver on
gates, this patch makes it non-voting.
* 'tox -e cover' is fixed
* Remove @memorized decorator from
dashboards.project.images.images.tables.filter_tenant_ids function.
[1] https://github.com/nose-devs/nose/issues/984
Depends-On: https://review.openstack.org/572095
Depends-On: https://review.openstack.org/572124
Depends-On: https://review.openstack.org/572390
Depends-On: https://review.openstack.org/572391
Related blueprint: improve-horizon-testing
Change-Id: I7fb2fd7dd40f301ea822154b9809a9a07610c507
Django 2.0 is now used in tox py35 job, so there is no need for
py35dj20 job. Instead, Django 1.11 with python3 is not covered.
- py35dj20 job is dropped from tox.ini.
- python3-django111 is added to tox.ini.
python3 is specified to basepython to avoid a specific python version.
- Zuul job to consume python3-django111 is added.
Note that horizon-openstack-tox-py35dj20 cannot be dropped
because this job is used by horizon plugins.
Change-Id: Ic3b5e06d591a6f1d667993d19dcddfaf40882dee
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Iceeaad2d6e31f3afeba5879ba3825caba437940d
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Since Cinder API v1 is removed in I03bf2db5bd7e2fdfb4f6032758ccaf2b348a82ba
we don't need _replace_v2_parameters function anymore.
Change-Id: I18c2787241f1dcbe4c0afc14a76630d9bfb1162a
It makes more sense to use <Location> directive rather than
<Directory> directive because HTTP requests are handled by
WSGI script and the directory paths are not actually referred.
The proposed approach is already used in DevStack and what we test.
This is a patch to follow up the discussion on the apache
configuration files in https://review.openstack.org/#/c/561802/.
Change-Id: I0c3111ed4d04c55ba31924d02bbf3eb416ec3412
When manually creating keypairs, underscore are allowed but
when creating keypairs while instanciating an instance, it's
not allowed. This patch solves this.
Change-Id: I0ad19bd1239b7c9ac18888d84e123e478cf40508
closes-bug: #1775030
Horizon can support several auth mechanisms, i.e. Keystone creds and
OpenID. User allowed to choose proper way of auth and disclaimer is
shown. But it is possible to allow choose from the only variant, and in
this case disclaimer also shown, which is confusing. Proposed patch fix
disclaimer display and makes it reasonable
Closes-bug: #1774623
Change-Id: Ib039c6fdf1e4cd21b5ebe426fe2a15355a37353c
Currently, the flavor list is random on the panel of booting
instance, which is not a good experience for end user. This
patch fixes it and adds test accordingly.
Closes-Bug: #1715042
Change-Id: Id5369ab75487d214a3395ba507b4394d4497903e
It was unable to upload image when horizon was running on python3,
there was a problem with closed file in new thread. This commit is
fixing this issue with added if clause whether horizon running on
python2 or python3 and correctly call close_called on file when
running on python3.
Change-Id: Ice178f6269ac527ba62b26d86976b5336987c922
Closes-Bug: #1773935
Just like the flavor sort issue, this is another regression issue
when we shift from the legacy launch instance wizard. By default,
the image list should be ordered by name.
Change-Id: Id619ad531f7e91326694ee90c112d6a7db0d14ad
Because Heat projects have been migrated to Storyboard,
the reference should be updated correctly.
Change-Id: I4f5eea84fe50ecb495dcd0167e521950387a4810
The prior commit for this was functional but not quite
correct. The policy rules currently in Horizon for
attach and detach of volumes don't exist in Nova and
are missing from the local copy of nova_policy.json and
from Nova generated policy files. The fix to use the
create instance copy of the rule only worked for attach
and not detach ( https://review.openstack.org/#/c/570071/ )
This commit updates detach as well, and should be correct
going forward based on the Nova policy rules at:
https://git.openstack.org/cgit/openstack/nova/tree/nova/policies/volumes_attachments.py
Change-Id: I07fccd6f12149cd88a049c46aa113dfd2b60bbaa
Closes-bug: 1772759
The attach_volume rule on the Compute Instances and Volume pages
does not match the rule in the nova_policy.json file, or what is
generated from an oslo policy generation on Nova. Update the rule
to match what is used in the default policy file, and what Nova
uses in its unit tests.
While looking at this, discovered that the detach_volume has a
similar problem, with no rule that matches at all. It may make sense
to have detach volume use similar permissions to attach
Change-Id: I40c709c7bb0c8538b56624dbfff1faea2eba9ee6
Closes-bug: 1772759
Horizon don't have related change which align with the
change in https://review.openstack.org/#/c/330285.
With this fix, horizon can work as expected
Change-Id: I5940c662a0bec2beaf4863e07f7244311ba51212
Closes-Bug: #1770326
Signed-off-by: GUO Larry <guo1017138@163.com>
