9 Commits

Author SHA1 Message Date
Jenkins
bea60a44e4 Merge "Bringing HACKING.rst in correspondence with tox.ini" 2014-09-19 00:35:25 +00:00
Tatiana Ovchinnikova
539c14e1c6 Remove #noqa from two common imports and add them to import_exceptions
We have two imports with #noqa: django.conf.urls.patterns and
django.conf.urls.url however using them is a standard way of creating
any urls.py module. So there are over 150 imports in Horizon code
where #noqa could be replaced with two lines in list of import_exceptions.

Change-Id: I81c3290e0dc958b5037dd6a87e44df18adfbe751
2014-09-16 14:08:28 +04:00
Tatiana Ovchinnikova
bb0b7f438f Bringing HACKING.rst in correspondence with tox.ini
Since there is a couple of new import exceptions in tox.ini,
we should add corresponding lines to HACKING.rst list.

Change-Id: Ia45eb9a5dcdc4db5205f235c85cfeab80c62d786
2014-09-16 13:03:01 +04:00
Felipe Reyes
af49cf1f15 Replace force_unicode with force_text
Django changed the name to force_unicode and it's only available in
python2 as an alias of force_text. The new name is available since
Django 1.4.2

Closes-Bug: #1345642
Change-Id: Ida8c545ceec7c31999f2497d540a0dc5a653d286
2014-08-06 14:34:53 +02:00
Radomir Dopieralski
028332da4a Remove #noqa from most common imports and add them to import_exceptions
We have a lot of import with #noqa that is there to ignore h302,
because it's traditional to import and use a name directly, instead
of a whole module. This hides other errors and gives people the
impression that it's actually fine to import non-modules, you just
have to slap #noqa on those lines.

I went through the code and identified about a dozen names that are
most commonly imported this way. I remove the #noqa tag from them,
and added them to the list in import_exceptions.

I also removed a few unused imports that were revealed in the process.

Change-Id: I27afb8e2b1d4759ec974ded9464d8f010312ee78
2014-01-07 12:26:35 +01:00
Radomir Dopieralski
e6467692d4 JavaScript use policy
Add a point to HACKING.rst pointing to the Horizon docs about
contributing.

Add information about JavaScript support policy to the contributing
docs.

The policy is based on:
http://lists.openstack.org/pipermail/openstack-dev/2013-November/020342.html

Change-Id: I16a51c7ab7faf68d6e7984c113da175c5c08650d
2013-12-10 14:34:42 +01:00
Joe Gordon
7ef29b2562 Make HACKING.rst formatting sync with other repos
Make HACKING.rst have the same format as in other OpenStack repos. When
working across multiple projects its nicer to have files have the same
formatting to reduce confusion.

Change-Id: I078f7ba512cfd8ccaf646e37287bcdbb11e54e90
2013-11-11 10:46:57 -08:00
Keshava Bharadwaj
01db7de2ca Updates OpenStack Style Commandments link
The current links in the HACKING file are broken. This references the
correct location for contributors to view.

Change-Id: I785ae8e01a7e88f7bc3b94c59ea0c35068fede13
2013-10-16 22:49:29 +05:30
Joe Gordon
8a069db554 Add HACKING.rst
Add HACKING.rst but instead of copying the file around point to the new
cannonical location for it
https://github.com/openstack-dev/hacking/blob/master/HACKING.rst

Also expand out the flake8 H series ignores, so they can be enabled one
by one.

Change-Id: I6ec39d00c3beabbc3e661754bac6e43a0fb351d6
2013-06-11 10:52:50 -07:00