openstack/ironic-inspector-specs
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2:

(3 comments)

Hey guys!

Thanks for your inputs!
I'll post an update briefly.

Cheers,
milan

Patch-set: 2
This commit is contained in:
Gerrit User 18653 2017-05-02 12:53:27 +00:00 committed by Gerrit Code Review
parent 867db8ce71
commit b3b6881b0d
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
a9f03270ce78ea7b09c1784e21a28d2af16db8d5
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_06494031",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 77,
"author": {
"id": 18653
},
"writtenOn": "2017-05-02T12:53:27Z",
"side": 1,
"message": "right, so I\u0027d update this to have the sync and get_periodic_sync_task, leaving the details of white/black list construction up to the driver implementation.",
"parentUuid": "5ff73747_6b481686",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_d13f2b23",
@ -69,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_032372c0",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 80,
"author": {
"id": 18653
},
"writtenOn": "2017-05-02T12:53:27Z",
"side": 1,
"message": "to maintain the type it would have to return a periodic.periodics(enabled\u003dFalse)(lambda: None) I guess but yeah, that was my idea: for a driver to be able to opt out from periodic syncing.",
"parentUuid": "5ff73747_4b61da04",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_b13a5f31",
@ -176,6 +212,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_0696e095",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 87,
"author": {
"id": 18653
},
"writtenOn": "2017-05-02T12:53:27Z",
"side": 1,
"message": "\u003e Also how are you going to use `update_filter`, out of the `sync` scope?\n\nvery true, I guess there\u0027s no usage to it outside of the sync method --- I\u0027ll update the spec to reflect it (w/o get_white/black_list or update_filter)",
"parentUuid": "5ff73747_64a62e56",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_9149a3d1",