Hacking's latest release is 0.11.0. Most other ironic projects are using
this release.
These updates are done project-by-project to avoid introducing
unexpected new hacking rules to projects. This version bump already
applies cleanly to ironic-lib with no code style changes.
Change-Id: I6e47390299bf8f073b8c8413f0cd4e1365f938bb
A failure may occur if the dd to config drive partition happens
before it actually becomes available. This change adds a udevadm
settle call that ensures that config drive device is present in
/dev folder.
Closes-Bug: #1633063
Change-Id: I5526f791371e7a6f4cdad151bb163707504e76cf
ironic has some test cases that check the internals of what ironic-lib
does. This adds some test cases to ironic-lib's work_on_disk method to
ensure coverage will stay up to par when those tests are purged from
ironic proper.
Change-Id: If9499982156e349056cffd87d62d1da172494204
Related-Bug: 1552843
This addresses a couple of issues with disk_utils.count_mbr_partitions()
and is a followup to I7042cd12775b0d715c15f466db2d4c5dc9e1a60a.
This fixes a typo as well as adds the device to the error string.
Change-Id: I010b8a8ebb34bf776ea22dc5fed13fe868b0d794
Related-Bug: #1629926
This patch is adding a new method called count_msdos_partitions()
responsible for counting the number of primary and logical partitions
in a MBR partition table.
Prior to this patch, the code checking if there were more than 4 primary
partitions present in the partiton table was using the list_partitions()
method which do not distinguish between the types*. So, even if the disk
had 2 primary and 5 logical partitions the check would fail thinking
that 7 primary partitions were present (which is impossible btw).
This patch make use of "partprobe" to count the partitions, which is
already required in ironic-lib.
* Not distinguishing types is a pro on the list_partitions() method
because primary and logical does not apply for others disk labels such
as GPT.
This patch also fix a small typo in a non-related string :-)
Change-Id: I7042cd12775b0d715c15f466db2d4c5dc9e1a60a
Closes-Bug: #1629926
Since we're running python 3.5 tests now, we should also be
running thme when running all tests with just `tox`.
Change-Id: Ic5d1c64d4cfccbc517f753bfe48aec13a16736e8
The check for determining if a device was GPT partioned was incorrect.
This was due to the fact that the blkid output for a GPT partioned
device would have been: ('gpt\n', '') and the test was checking for
'gpt' in the output.
Change-Id: Ifdae7c5bfe01d100b1a94e83a4475ac2523483dc
Closes-Bug: #1626671
This patch is adding a function called match_root_device_hints() to the
utils.py module. This function tries to find a device that matches all the
given root device hints.
Closes-Bug: #1561137
Change-Id: Ia3ad098d6334ba22387c0f6d17b4bd518b178ca9
Sync tools/tox_install.sh with python-openstackclient. This brings in
the following improvements:
* Do not leave temporary directory around, instead delete temporary
directory directly after usage (change
I939eae82dba3287fd4e4086128ebf4609a0e0770).
* Do not set ZUUL_BRANCH explicitely and remove unused if condition
(change I0077c986a17d6bb92791474e03d1e77776e9382f).
Change-Id: I455222311fb1e9e029cb586c8cc6a06debaaa225
This patch is extending the parse_root_device_hints() method to make it
work with the oslo.utils operators.
Partial-Bug: #1561137
Change-Id: I9ab7357e396b89e1fe0c326d9bdfaca71916910e
Following OpenStack Style Guidelines:
http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises
[H203] Unit test assertions tend to give better messages for more specific assertions.
As a result, assertIsNone(...) is preferred over assertEqual(None, ...)
Change-Id: Id34fb0851d698ed9c1c77cbb230f32aa21678c4e
When an exception was caught and rethrown, it should call 'raise'
without any arguments because it shows the place where an exception
occured initially instead of place where the exception re-raised.
Change-Id: I112eeea489470bca34b588bd862500d615c84e67
Adds developer documentation to ironic-lib index page about how to emit
metrics and what each metric type is useful for.
Change-Id: I3e835717aa141f0e0fa0f026b910b9a9ed60665e
Partial-bug: #1611559
This patch fixes all sphinx warnings generated by malformed docstrings.
Additionally, it contains formatting and accuracy fixes for the metrics
docstrings, to ensure blockquotes are properly rendered, and to indicate
the get_metrics_logger() method is actually in metrics_utils.
Finally, this adds doc8 to the pep8 job, ensuring we don't reintroduce
some of these errors. As a note, there are items that can cause warnings
in doc builds that aren't enforced by doc8, and can't be enforced until
a doc build job is added to project-config.
Change-Id: I622812bfe8af576ab215c098dd211c6faf697a0c
Partial-bug: #1614272
Partial-bug: #1611559
This adds a doc build for ironic-lib. Currently the only documentation
is that generated from docstrings.
Change-Id: I6ee00ad863bc7ce72958db4e8d5b6871a5b96eb0
Partial-bug: #1614272
This will work for UEFI only or BIOS only images. It will not
work for hybrid images; which are capable of boot from BIOS
and UEFI boot mode.
Partial-Bug: #1493328
Change-Id: I4c517f63d620b5a9de31ecb2d7c209776d5ded48
