ironic-python-agent-builder/68c044d9b0e6c323cf94eb8f9d4...

127 lines
3.7 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "53679006_746fdae9",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15519
},
"writtenOn": "2022-04-01T17:01:20Z",
"side": 1,
"message": "recheck",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "94df0c40_f76756de",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 10239
},
"writtenOn": "2022-04-04T09:57:06Z",
"side": 1,
"message": "We\u0027re going to break TripleO if we just copy the element with the same name: https://opendev.org/openstack/tripleo-image-elements/src/branch/master/elements/ironic-agent-multipath.\n\nNothing in the element seems to be ironic-agent specific, right? Maybe just call it \"iscsi-multipath\" or something like that? It could even go to DIB itself, but I understand that it will take time.",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "800ad770_b30eccf3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 11655
},
"writtenOn": "2022-04-04T21:50:54Z",
"side": 1,
"message": "perhaps just \"multipath-io\"\n\nThe iscsi portion is disjointed.",
"parentUuid": "94df0c40_f76756de",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "38c408af_be51ab2d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15519
},
"writtenOn": "2022-04-04T23:22:12Z",
"side": 1,
"message": "ack",
"parentUuid": "800ad770_b30eccf3",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7114406a_1d9e0fe3",
"filename": "dib/ironic-agent-multipath/element-deps",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 10239
},
"writtenOn": "2022-04-04T09:57:06Z",
"side": 1,
"message": "Is this really needed? I don\u0027t think so.",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "77046d73_d645901c",
"filename": "dib/ironic-agent-multipath/element-deps",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 11655
},
"writtenOn": "2022-04-04T21:50:54Z",
"side": 1,
"message": "+1, the key is mutlipathd aiui.",
"parentUuid": "7114406a_1d9e0fe3",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "90bbd140_1c9c5175",
"filename": "dib/ironic-agent-multipath/element-deps",
"patchSetId": 2
},
"lineNbr": 3,
"author": {
"id": 15519
},
"writtenOn": "2022-04-04T23:22:12Z",
"side": 1,
"message": "Done",
"parentUuid": "77046d73_d645901c",
"revId": "68c044d9b0e6c323cf94eb8f9d4837369bd60415",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}