openstack/ironic-python-agent
Code Issues Proposed changes

Merge "Reduce logging verbosity when collecting logs"

Browse Source
This commit is contained in:
Zuul
2021-06-14 09:22:53 +00:00
committed by Gerrit Code Review
parent 12dbe3ddb7 2fcf35e56d
commit 8afc176c28
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ironic_python_agent/utils.py
View File

@@ -478,7 +478,6 @@ def get_command_output(command):
except (processutils.ProcessExecutionError, OSError) as e: except (processutils.ProcessExecutionError, OSError) as e:
error_msg = ('Failed to get the output of the command "%(command)s". ' error_msg = ('Failed to get the output of the command "%(command)s". '
'Error: %(error)s' % {'command': command, 'error': e}) 'Error: %(error)s' % {'command': command, 'error': e})
LOG.error(error_msg)
raise errors.CommandExecutionError(error_msg) raise errors.CommandExecutionError(error_msg)
return io.BytesIO(out) return io.BytesIO(out)
@@ -547,7 +546,7 @@ def collect_system_logs(journald_max_lines=None):
try: try:
io_dict[file_name] = get_command_output(command) io_dict[file_name] = get_command_output(command)
except errors.CommandExecutionError: except errors.CommandExecutionError:
pass LOG.debug('Collecting logs from command %s has failed', command)
io_dict = {} io_dict = {}
file_list = [] file_list = []