openstack/ironic-python-agent
Code Issues Proposed changes

Software RAID: Call udev_settle before creation

Browse Source 
This patch fixes a race during software RAID creation:
we create the partition with parted, the kernel then
notifies udev, but we need to wait for udevd to create
the device files before calling mdadm to create the
md device.

Credits to jcosmao for finding this.

Change-Id: I642f28acc351cf50263e37dfbc8468bf59de2cc5
(cherry picked from commit 9d707e9f4b)
This commit is contained in:
Arne Wiebalck
2021-10-04 16:57:56 +02:00
committed by Dmitry Tantsur
parent ae1537d9c6
commit aa2cd29db7
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ironic_python_agent/hardware.py
View File

@@ -2090,6 +2090,13 @@ class GenericHardwareManager(HardwareManager):
utils.execute('parted', device, '-s', '-a',
'optimal', '--', 'mkpart', 'primary',
start_str, end_str)
# Parted/udev partition creation is asynchronous.
# Wait for udev events to be processed before going to
# next step. This avoids getting errors at mdadm
# create because a device is not ready yet.
_udev_settle()
# Necessary, if we want to avoid hitting
# an error when creating the mdadm array below
# 'mdadm: cannot open /dev/nvme1n1p1: No such file

7
releasenotes/notes/fix-nvme-software-raid-race-2e0e104de9611228.yaml Normal file
View File

@@ -0,0 +1,7 @@
---
fixes:
- |
Fixes a race on software RAID creation: since the creation of
partitions is asynchronous, we need to wait for all udev events
to be processed before we can use the partitions to create an
md device.