openstack/ironic-python-agent
Code Issues Proposed changes

Merge "Using assertIsNone() is preferred over assertEqual()"

Browse Source
This commit is contained in:
Jenkins
2016-08-29 18:43:18 +00:00
committed by Gerrit Code Review
parent 4facf2c385 814b60def3
commit aa4c889a06
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ironic_python_agent/tests/unit/test_hardware.py
View File

@@ -328,7 +328,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase):
self.assertEqual('eth0', interfaces[0].name) self.assertEqual('eth0', interfaces[0].name)
self.assertEqual('00:0c:29:8c:11:b1', interfaces[0].mac_address) self.assertEqual('00:0c:29:8c:11:b1', interfaces[0].mac_address)
self.assertEqual('192.168.1.2', interfaces[0].ipv4_address) self.assertEqual('192.168.1.2', interfaces[0].ipv4_address)
self.assertEqual(None, interfaces[0].lldp) self.assertIsNone(interfaces[0].lldp)
self.assertTrue(interfaces[0].has_carrier) self.assertTrue(interfaces[0].has_carrier)
@mock.patch('ironic_python_agent.netutils.get_lldp_info') @mock.patch('ironic_python_agent.netutils.get_lldp_info')
@@ -396,7 +396,7 @@ class TestGenericHardwareManager(test_base.BaseTestCase):
self.assertEqual('eth0', interfaces[0].name) self.assertEqual('eth0', interfaces[0].name)
self.assertEqual('00:0c:29:8c:11:b1', interfaces[0].mac_address) self.assertEqual('00:0c:29:8c:11:b1', interfaces[0].mac_address)
self.assertEqual('192.168.1.2', interfaces[0].ipv4_address) self.assertEqual('192.168.1.2', interfaces[0].ipv4_address)
self.assertEqual(None, interfaces[0].lldp) self.assertIsNone(interfaces[0].lldp)
self.assertTrue(interfaces[0].has_carrier) self.assertTrue(interfaces[0].has_carrier)
@mock.patch('netifaces.ifaddresses') @mock.patch('netifaces.ifaddresses')