openstack/ironic-python-agent
Code Issues Proposed changes

Improve __str__ method of BaseCommandResult

Browse Source 
Fixes nits raised in review for Change ID
I3ca0382f05e88700c56d3c7f4b4ecf7b8fc3bc0c

Remove useless id field, fix capitalization and grammar.

Change-Id: I7976993d1ac9354e035a5e7dba6ef8cc392537e3
This commit is contained in:
Jay Faulkner 2016-03-30 17:54:47 +00:00
parent d1060c0469
commit b176f29b3d
1 changed files with 5 additions and 4 deletions

9
ironic_python_agent/extensions/base.py

@ -56,10 +56,11 @@ class BaseCommandResult(encoding.SerializableComparable):
self.command_result = None
def __str__(self):
return ("Command ID: %(id)s, Name: %(name)s "
"Params: %(params)s Status: %(status)s (%(result)s)" %
{"id": self.id, "name": self.command_name,
"params": self.command_params, "status": self.command_status,
return ("Command name: %(name)s, "
"params: %(params)s, status: %(status)s, result: "
"%(result)s." %
{"name": self.command_name, "params": self.command_params,
"status": self.command_status,
"result": self.command_result})
def is_done(self):