openstack
/
ironic-python-agent
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 10239 \u003c10239@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10239\u003e replied on the change"}
This commit is contained in:
Gerrit User 10239 2024-04-09 09:12:47 +00:00 committed by Gerrit Code Review
parent be19aab4e4
commit c1a55c6e67
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
7e087f7c25442472dad3b854fb98310a5cfca6d8
View File

@ -105,6 +105,24 @@
"revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7d70f96d_bc2e5f74",
"filename": "ironic_python_agent/hardware.py",
"patchSetId": 3
},
"lineNbr": 2571,
"author": {
"id": 10239
},
"writtenOn": "2024-04-09T09:12:47Z",
"side": 1,
"message": "Sorry for confusing you, it was a side comment about write_image. But yes, thinking about it, clean_uefi_nvram is questionable as a service step - too easy to corrupt the deployment and also easy enough to do from within the machine.",
"parentUuid": "0e49ccac_4ba48b69",
"revId": "7e087f7c25442472dad3b854fb98310a5cfca6d8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {