openstack/ironic-python-agent
Code Issues Proposed changes

Warn when smartctl not found

Browse Source 
Currently, if smartctl is not found by IPA, it will silently skip ATA
secure erase and proceed to shred (if enabled). This is supposedly for
backwards compatibility, but is quite hard to diagnose.

This change adds a warning message to make it more obvious what is
happening.

TrivialFix

Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93
(cherry picked from commit b68fa6b2e1)
This commit is contained in:
Mark Goddard
2022-06-24 16:47:18 +01:00
parent f11ae6a072
commit c9d00d9278
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ironic_python_agent/hardware.py
View File

@@ -1688,10 +1688,11 @@ class GenericHardwareManager(HardwareManager):
'ATA commands via the `smartctl` utility with device ' 'ATA commands via the `smartctl` utility with device '
'%s do not succeed.', block_device.name) '%s do not succeed.', block_device.name)
return False return False
except OSError: except OSError as e:
# Processutils can raise OSError if a path is not found, # Processutils can raise OSError if a path is not found,
# and it is okay that we tollerate that since it was the # and it is okay that we tollerate that since it was the
# prior behavior. # prior behavior.
LOG.warning('Unable to execute `smartctl` utility: %s', e)
return True return True
def _ata_erase(self, block_device): def _ata_erase(self, block_device):