openstack/ironic-python-agent
Code Issues Proposed changes

Remove nvme-cli warning and delay on nvme-format

Browse Source 
This change adds '-f' flag to nvme-cli calls during NVMe Secure Erase.
This removes nvme-cli output warning that the device is about to be
irreversibly deleted as well as the related 10 second delay which is
pointlessly increasing NVMe cleaning time.

Story: 2008290
Change-Id: I7b7b8b7d4f643b07d5c9dcf7ec35cf7ebedf44d1
This commit is contained in:
Jacob Anders 2021-03-02 15:37:35 +10:00
parent 4a22c887f8
commit d2127e7ef4
2 changed files with 3 additions and 3 deletions
ironic_python_agent
hardware.py
tests/unit
test_hardware.py

2
ironic_python_agent/hardware.py

@ -1690,7 +1690,7 @@ class GenericHardwareManager(HardwareManager):
LOG.debug("Attempting to nvme-format %s using secure format mode "
"(ses) %s", block_device.name, format_mode)
utils.execute('nvme', 'format', block_device.name, '-s',
format_mode)
format_mode, '-f')
LOG.info("nvme-cli format for device %s (ses= %s ) completed "
"successfully.", block_device.name, format_mode)
return True

4
ironic_python_agent/tests/unit/test_hardware.py

@ -3886,7 +3886,7 @@ class TestGenericHardwareManager(base.IronicAgentTest):
retval = self.hardware._nvme_erase(block_device)
mocked_execute.assert_has_calls([
mock.call('nvme', 'id-ctrl', '/dev/nvme0n1', '-o', 'json'),
mock.call('nvme', 'format', '/dev/nvme0n1', '-s', 2),
mock.call('nvme', 'format', '/dev/nvme0n1', '-s', 2, '-f'),
])
self.assertTrue(retval)
@ -3910,7 +3910,7 @@ class TestGenericHardwareManager(base.IronicAgentTest):
retval = self.hardware._nvme_erase(block_device)
mocked_execute.assert_has_calls([
mock.call('nvme', 'id-ctrl', '/dev/nvme0n1', '-o', 'json'),
mock.call('nvme', 'format', '/dev/nvme0n1', '-s', 1),
mock.call('nvme', 'format', '/dev/nvme0n1', '-s', 1, '-f'),
])
self.assertTrue(retval)