openstack/ironic-python-agent
Code Issues Proposed changes

Documentation follow-up to the LLDP patch

Browse Source 
Documentation follow-up to the LLDP patch, commit
a7f0af722f96950e3bf67e26b922f80c1bd503ab. Provide the meaning of the
acronymns TLV and LLDP.

Change-Id: Icce3eb5519dfcfc9b6f7e23003cf056646da6c50
This commit is contained in:
John L. Villalovos 2016-06-24 13:00:12 -07:00
parent 50ddb894b4
commit d89dfb1b26
2 changed files with 8 additions and 7 deletions
doc/source
index.rst
ironic_python_agent
hardware.py

11
doc/source/index.rst

@ -111,11 +111,12 @@ fields:
``interfaces``
list of network interfaces with fields: ``name``, ``mac_address``,
``ipv4_address``, ``lldp``. If configuration option ``collect_lldp`` is
set to True the ``lldp`` field will be populated by a list of TLVs pulled
from LLDP. Currently IPA also returns 2 fields ``switch_port_descr`` and
``switch_chassis_descr`` which were reserved for future use, these are now
deprecated to be removed in Ocata in favor of including all LLDP data in
the ``lddp`` field.
set to True the ``lldp`` field will be populated by a list of
type-length-value (TLV) fields retrieved using the Link Layer Discovery
Protocol (LLDP). Currently IPA also returns 2 fields ``switch_port_descr``
and ``switch_chassis_descr`` which were reserved for future use, these are
now deprecated to be removed in Ocata in favor of including all LLDP data
in the ``lddp`` field.
``system_vendor``
system vendor information from SMBIOS as reported by ``dmidecode``:

4
ironic_python_agent/hardware.py

@ -457,8 +457,8 @@ class GenericHardwareManager(HardwareManager):
# to get data to replace it so just return.
return
for ifname, tlvs in raw_lldp_data.items():
# NOTE(sambetts) Convert each tlv value to hex so that it can be
# serialised safely
# NOTE(sambetts) Convert each type-length-value (TLV) value to hex
# so that it can be serialised safely
processed_tlvs = []
for typ, data in tlvs:
try: