324f037eb0
sync_command and async_command in ironic_python_agent/extensions/base.py
are implemented so that they change decorated method signature,
which is really bad practice. Example:
@sync_command
def orig_method(self, **kw):
...
sync_command decorator returns lambda which has one additional
argument 'command_name'
def sync_command(func):
def decorated(self, command_name, **kw):
...
func(self, **kw)
...
return decorated
Additional parameter 'command_name' is moved from decorated function to
decorator signature in both decorators. Every call of decorated functions
is fixed, BaseAgentExtension.execute is updated to not send this extra
argument. BaseAgentExtension.__init__ automatically generates command_map
from decorated methods.
Change-Id: Iff0f495bc8d9c731892feb0f4759a7f10ee76328
Closes-Bug: 1314148
32 lines
1.2 KiB
Python
32 lines
1.2 KiB
Python
# Copyright 2013 Rackspace, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import mock
|
|
from oslotest import base as test_base
|
|
|
|
from ironic_python_agent.extensions import decom
|
|
|
|
|
|
class TestDecomExtension(test_base.BaseTestCase):
|
|
def setUp(self):
|
|
super(TestDecomExtension, self).setUp()
|
|
self.agent_extension = decom.DecomExtension()
|
|
|
|
@mock.patch('ironic_python_agent.hardware.get_manager', autospec=True)
|
|
def test_erase_hardware(self, mocked_get_manager):
|
|
hardware_manager = mocked_get_manager.return_value
|
|
result = self.agent_extension.erase_hardware()
|
|
result.join()
|
|
hardware_manager.erase_devices.assert_called_once_with()
|