openstack
/
ironic-specs
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 11655 \u003c11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_11655\u003e replied on the change"}
This commit is contained in:
Gerrit User 11655 2024-05-04 00:00:55 +00:00 committed by Gerrit Code Review
parent de7b84aa05
commit 3d63f221b8
1 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
6aeec08df09662a289b7ef8a59d79a3c00dd3d8d
View File

@ -87,6 +87,46 @@
"parentUuid": "e47ca181_a98b55dc",
"revId": "6aeec08df09662a289b7ef8a59d79a3c00dd3d8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e85c4690_a33c87b2",
"filename": "specs/approved/mercury.rst",
"patchSetId": 4
},
"lineNbr": 349,
"author": {
"id": 11655
},
"writtenOn": "2024-05-04T00:00:55Z",
"side": 1,
"message": "As a practical note, I\u0027d swap these. I started seeing how I\u0027d wire in a genericized interface in, and realize it would just be best to figure out what I need to call *first* to prototype the mapping for the service.",
"revId": "6aeec08df09662a289b7ef8a59d79a3c00dd3d8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2df37ddb_2b6d9343",
"filename": "specs/approved/mercury.rst",
"patchSetId": 4
},
"lineNbr": 352,
"author": {
"id": 11655
},
"writtenOn": "2024-05-04T00:00:55Z",
"side": 1,
"message": "It looks like we may have already done this as a result of refactoring/cleanup in the last few cycles. It *appears* we can just post a id number in and we should be golden regarding this.",
"range": {
"startLine": 351,
"startChar": 0,
"endLine": 352,
"endChar": 69
},
"revId": "6aeec08df09662a289b7ef8a59d79a3c00dd3d8d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}