openstack
/
ironic-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 23851 <23851@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, fbb117837793639285725a624bfbe93414e7a9ca
This commit is contained in:
Gerrit User 23851 2024-05-03 12:55:09 +00:00 committed by Gerrit Code Review
parent 3faf35650f
commit 52760fe115
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
f20835d47685a7069fcbde0bc077c6b5bbc93ce0 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "37f15dc6_e5047d6b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 23851
},
"writtenOn": "2024-05-03T12:55:09Z",
"side": 1,
"message": "Not sure what error are you seeing, I just ran tox docs command on my system with python 3.12.2 and it went well\nbesides that, I don\u0027t think pinning a python version would help in this case, it would probably cause potential issues due to excluding all the other versions we\u0027re testing in CI.\nA solution could be defining an env variable that can be overridden and set its default to system python.\nsomething like:\nbasepython \u003d {env:TOX_PYTHON:python}\nunder testenv",
"revId": "f20835d47685a7069fcbde0bc077c6b5bbc93ce0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}