openstack
/
ironic-specs
Code Issues Proposed changes

Correct RAID approved spec JSON 

The original example dictionaries added to the RAID spec
used single quotes instead of double quotes. Since double quotes
are used in JSON, as opposed to dictionaries, to represent a string,
they were failing JSON validation and could not be directly used.

Changed the single quotes to double quotes where appropriate
in the RAID spec and passed each example through a JSON
validator which now returns that the example is valid JSON.

Change-Id: I11c7258d30194d7841d5b0312d45243dee9953d6
Partial-bug: #1586157
This commit is contained in:
Bharath kumar 2016-06-07 09:58:09 +00:00
parent 90db786b51
commit 7bdf2c4819
1 changed files with 30 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
specs/approved/ironic-generic-raid-interface.rst
View File

@ -124,23 +124,23 @@ Proposed change
Example 1 (using backing physical disk hints)::
{
'logical_disks':
"logical_disks":
[
{
'size_gb': 50,
'raid_level': '1+0',
'disk_type': 'hdd',
'interface_type': 'sas',
'volume_name': 'root_volume',
'is_root_volume': 'true'
"size_gb": 50,
"raid_level": "1+0",
"disk_type": "hdd",
"interface_type": "sas",
"volume_name": "root_volume",
"is_root_volume": "true"
},
{
'size_gb': 100,
'number_of_physical_disks': 3,
'raid_level': '5',
'disk_type': 'hdd',
'interface_type': 'sas'
'volume_name': 'data_volume'
"size_gb": 100,
"number_of_physical_disks": 3,
"raid_level": "5",
"disk_type": "hdd",
"interface_type": "sas"
"volume_name": "data_volume"
}
]
}
@ -148,28 +148,28 @@ Proposed change
Example 2 (using backing physical disks)::
{
'logical_disks':
"logical_disks":
[
{
'size_gb': 50,
'raid_level': '1+0',
'controller': 'RAID.Integrated.1-1',
'volume_name': 'root_volume',
'is_root_volume': 'true'
'physical_disks': [
'Disk.Bay.0:Encl.Int.0-1:RAID.Integrated.1-1',
'Disk.Bay.1:Encl.Int.0-1:RAID.Integrated.1-1'
"size_gb": 50,
"raid_level": "1+0",
"controller": "RAID.Integrated.1-1",
"volume_name": "root_volume",
"is_root_volume": "true"
"physical_disks": [
"Disk.Bay.0:Encl.Int.0-1:RAID.Integrated.1-1",
"Disk.Bay.1:Encl.Int.0-1:RAID.Integrated.1-1"
]
},
{
'size_gb': 100,
'raid_level': '5',
'controller': 'RAID.Integrated.1-1',
'volume_name': 'data_volume'
'physical_disks': [
'Disk.Bay.2:Encl.Int.0-1:RAID.Integrated.1-1',
'Disk.Bay.3:Encl.Int.0-1:RAID.Integrated.1-1',
'Disk.Bay.4:Encl.Int.0-1:RAID.Integrated.1-1'
"size_gb": 100,
"raid_level": "5",
"controller": "RAID.Integrated.1-1",
"volume_name": "data_volume"
"physical_disks": [
"Disk.Bay.2:Encl.Int.0-1:RAID.Integrated.1-1",
"Disk.Bay.3:Encl.Int.0-1:RAID.Integrated.1-1",
"Disk.Bay.4:Encl.Int.0-1:RAID.Integrated.1-1"
]
}
]