Merge "Suffix the ISO names with '.iso'"

This commit is contained in:
Zuul 2020-09-02 19:40:20 +00:00 committed by Gerrit Code Review
commit 32926667d4
3 changed files with 10 additions and 4 deletions

View File

@ -192,7 +192,7 @@ def _get_iso_image_name(node):
:param node: the node for which image name is to be provided.
"""
return "boot-%s" % node.uuid
return "boot-%s.iso" % node.uuid
def cleanup_iso_image(task):

View File

@ -223,7 +223,7 @@ class RedfishImageUtilsTestCase(db_base.DbTestCase):
shared=True) as task:
image_utils.cleanup_iso_image(task)
object_name = 'boot-%s' % task.node.uuid
object_name = 'boot-%s.iso' % task.node.uuid
mock_unpublish.assert_called_once_with(mock.ANY, object_name)
@ -244,7 +244,7 @@ class RedfishImageUtilsTestCase(db_base.DbTestCase):
task, 'http://kernel/img', 'http://ramdisk/img',
'http://bootloader/img', root_uuid=task.node.uuid)
object_name = 'boot-%s' % task.node.uuid
object_name = 'boot-%s.iso' % task.node.uuid
mock_publish_image.assert_called_once_with(
mock.ANY, mock.ANY, object_name)
@ -275,7 +275,7 @@ class RedfishImageUtilsTestCase(db_base.DbTestCase):
task, 'http://kernel/img', 'http://ramdisk/img',
bootloader_href=None, root_uuid=task.node.uuid, base_iso=None)
object_name = 'boot-%s' % task.node.uuid
object_name = 'boot-%s.iso' % task.node.uuid
mock_publish_image.assert_called_once_with(
mock.ANY, mock.ANY, object_name)

View File

@ -0,0 +1,6 @@
---
fixes:
- |
Add the suffix ".iso" for the ISO images generated by Ironic, as some
hardwares can not load the ISO images if they are not suffixed with
".iso". It is also recommended to name the files with proper extensions.