openstack/ironic
Code Issues Proposed changes

Merge "Fix fake.FakeBoot.prepare_ramdisk() signature"

Browse Source
This commit is contained in:
Jenkins
2016-07-19 10:30:05 +00:00
committed by Gerrit Code Review
parent 12094c5da7 6c1aa56429
commit 5381114b98
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/drivers/modules/fake.py
View File

@@ -63,7 +63,7 @@ class FakeBoot(base.BootInterface):
def validate(self, task):
pass
def prepare_ramdisk(self, task):
def prepare_ramdisk(self, task, ramdisk_params):
pass
def clean_up_ramdisk(self, task):

10
ironic/tests/unit/drivers/test_fake.py
View File

@@ -43,9 +43,9 @@ class FakeDriverTestCase(db_base.DbTestCase):
self.task.driver = self.driver
def test_driver_interfaces(self):
# fake driver implements only 5 out of 6 interfaces
self.assertIsInstance(self.driver.power, driver_base.PowerInterface)
self.assertIsInstance(self.driver.deploy, driver_base.DeployInterface)
self.assertIsInstance(self.driver.boot, driver_base.BootInterface)
self.assertIsInstance(self.driver.vendor, driver_base.VendorInterface)
self.assertIsInstance(self.driver.console,
driver_base.ConsoleInterface)
@@ -78,6 +78,14 @@ class FakeDriverTestCase(db_base.DbTestCase):
self.driver.deploy.clean_up(None)
self.driver.deploy.tear_down(None)
def test_boot_interface(self):
self.assertEqual({}, self.driver.boot.get_properties())
self.driver.boot.validate(self.task)
self.driver.boot.prepare_ramdisk(self.task, {})
self.driver.boot.clean_up_ramdisk(self.task)
self.driver.boot.prepare_instance(self.task)
self.driver.boot.clean_up_instance(self.task)
def test_console_interface(self):
self.assertEqual({}, self.driver.console.get_properties())
self.driver.console.validate(self.task)