Merge "Make bootloader installation failures fatal for whole disk images"
This commit is contained in:
commit
bded82a27e
|
@ -1335,20 +1335,11 @@ class AgentDeployMixin(HeartbeatMixin, AgentOobStepsMixin):
|
||||||
software_raid=software_raid
|
software_raid=software_raid
|
||||||
)
|
)
|
||||||
if result['command_status'] == 'FAILED':
|
if result['command_status'] == 'FAILED':
|
||||||
if not whole_disk_image:
|
msg = (_("Failed to install a bootloader when "
|
||||||
msg = (_("Failed to install a bootloader when "
|
"deploying node %(node)s. Error: %(error)s") %
|
||||||
"deploying node %(node)s. Error: %(error)s") %
|
{'node': node.uuid,
|
||||||
{'node': node.uuid,
|
'error': agent_client.get_command_error(result)})
|
||||||
'error': agent_client.get_command_error(result)})
|
log_and_raise_deployment_error(task, msg)
|
||||||
log_and_raise_deployment_error(task, msg)
|
|
||||||
else:
|
|
||||||
# Its possible the install will fail if the IPA image
|
|
||||||
# has not been updated, log this and continue
|
|
||||||
LOG.info('Could not install bootloader for whole disk '
|
|
||||||
'image for node %(node)s, Error: %(error)s"',
|
|
||||||
{'node': node.uuid,
|
|
||||||
'error': agent_client.get_command_error(result)})
|
|
||||||
return
|
|
||||||
|
|
||||||
try:
|
try:
|
||||||
persistent = True
|
persistent = True
|
||||||
|
|
|
@ -0,0 +1,7 @@
|
||||||
|
---
|
||||||
|
upgrade:
|
||||||
|
- |
|
||||||
|
Bootloader installation failures are now fatal for whole disk images.
|
||||||
|
Previously these failures were ignored to facilitate backwards
|
||||||
|
compatibility with older Ironic Python Agents, however we can now rely on
|
||||||
|
having a sufficiently modern IPA.
|
Loading…
Reference in New Issue