6e981156c8
This change moves the check on network interface to driver_factory.py and moves node creation from API to conductor side. A new exception InterfaceNotFoundInEntrypoint (similar to DriverNotFoundInEntrypoint) was introduced for the case when invalid interface is requested either during creation or during updating. The current approach already duplicates the check in two places. With the driver composition in place it will not be quite possible: different conductors may have different interfaces enabled as long as no hardware type ends up with different interfaces on different conductors. Also when calculating the defaults, we'll need access to a real hardware type object, which may not be possible on API side. Also there is a demand for driver-side validations on creation (e.g. detecting duplicating IPMI addresses), which also requires creation to happen on conductor side. Such features, however, are out of scope for this change. A side effect of this change is that objects.Node.network_interface is now defined the same way as other interfaces (i.e. nullable string). Also added more clean ups to base unit test class, as otherwise newly added tests randomly break other tests. Change-Id: Id1da20ccd5bb50e61a82449ef3d2ffce91822d71 Partial-Bug: #1524745 |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| base_manager.py | ||
| manager.py | ||
| notification_utils.py | ||
| rpcapi.py | ||
| task_manager.py | ||
| utils.py | ||