Split policy backend tests
Where to put a new test ? Is this behavior covered yet ? These and other questions require understanding the test coverage to be answered. test_backend.py is a huge test file, making it hard to understand what cases are currently covered for each backend. This chain of changes proposes to split it by the backends it covers; the tests will be placed into 'unit/{backend}/test_backends.py'. This change splits the tests for the policy backend. Change-Id: If88270a684d891e51f4ff45fa9b14626c0983541
This commit is contained in:
parent
70dfe056a3
commit
fe43a867f0
|
@ -0,0 +1,86 @@
|
|||
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
||||
# not use this file except in compliance with the License. You may obtain
|
||||
# a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
||||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
|
||||
import uuid
|
||||
|
||||
from keystone import exception
|
||||
from keystone.tests import unit
|
||||
|
||||
|
||||
class PolicyTests(object):
|
||||
def test_create(self):
|
||||
ref = unit.new_policy_ref()
|
||||
res = self.policy_api.create_policy(ref['id'], ref)
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_get(self):
|
||||
ref = unit.new_policy_ref()
|
||||
res = self.policy_api.create_policy(ref['id'], ref)
|
||||
|
||||
res = self.policy_api.get_policy(ref['id'])
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_list(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.policy_api.create_policy(ref['id'], ref)
|
||||
|
||||
res = self.policy_api.list_policies()
|
||||
res = [x for x in res if x['id'] == ref['id']][0]
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_update(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.policy_api.create_policy(ref['id'], ref)
|
||||
orig = ref
|
||||
|
||||
ref = unit.new_policy_ref()
|
||||
|
||||
# (cannot change policy ID)
|
||||
self.assertRaises(exception.ValidationError,
|
||||
self.policy_api.update_policy,
|
||||
orig['id'],
|
||||
ref)
|
||||
|
||||
ref['id'] = orig['id']
|
||||
res = self.policy_api.update_policy(orig['id'], ref)
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_delete(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.policy_api.create_policy(ref['id'], ref)
|
||||
|
||||
self.policy_api.delete_policy(ref['id'])
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.delete_policy,
|
||||
ref['id'])
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.get_policy,
|
||||
ref['id'])
|
||||
res = self.policy_api.list_policies()
|
||||
self.assertFalse(len([x for x in res if x['id'] == ref['id']]))
|
||||
|
||||
def test_get_policy_returns_not_found(self):
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.get_policy,
|
||||
uuid.uuid4().hex)
|
||||
|
||||
def test_update_policy_returns_not_found(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.update_policy,
|
||||
ref['id'],
|
||||
ref)
|
||||
|
||||
def test_delete_policy_returns_not_found(self):
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.delete_policy,
|
||||
uuid.uuid4().hex)
|
|
@ -988,76 +988,6 @@ class IdentityTests(object):
|
|||
self.assertDictEqual(updated_user_ref, user_ref)
|
||||
|
||||
|
||||
class PolicyTests(object):
|
||||
def test_create(self):
|
||||
ref = unit.new_policy_ref()
|
||||
res = self.policy_api.create_policy(ref['id'], ref)
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_get(self):
|
||||
ref = unit.new_policy_ref()
|
||||
res = self.policy_api.create_policy(ref['id'], ref)
|
||||
|
||||
res = self.policy_api.get_policy(ref['id'])
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_list(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.policy_api.create_policy(ref['id'], ref)
|
||||
|
||||
res = self.policy_api.list_policies()
|
||||
res = [x for x in res if x['id'] == ref['id']][0]
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_update(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.policy_api.create_policy(ref['id'], ref)
|
||||
orig = ref
|
||||
|
||||
ref = unit.new_policy_ref()
|
||||
|
||||
# (cannot change policy ID)
|
||||
self.assertRaises(exception.ValidationError,
|
||||
self.policy_api.update_policy,
|
||||
orig['id'],
|
||||
ref)
|
||||
|
||||
ref['id'] = orig['id']
|
||||
res = self.policy_api.update_policy(orig['id'], ref)
|
||||
self.assertDictEqual(ref, res)
|
||||
|
||||
def test_delete(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.policy_api.create_policy(ref['id'], ref)
|
||||
|
||||
self.policy_api.delete_policy(ref['id'])
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.delete_policy,
|
||||
ref['id'])
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.get_policy,
|
||||
ref['id'])
|
||||
res = self.policy_api.list_policies()
|
||||
self.assertFalse(len([x for x in res if x['id'] == ref['id']]))
|
||||
|
||||
def test_get_policy_returns_not_found(self):
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.get_policy,
|
||||
uuid.uuid4().hex)
|
||||
|
||||
def test_update_policy_returns_not_found(self):
|
||||
ref = unit.new_policy_ref()
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.update_policy,
|
||||
ref['id'],
|
||||
ref)
|
||||
|
||||
def test_delete_policy_returns_not_found(self):
|
||||
self.assertRaises(exception.PolicyNotFound,
|
||||
self.policy_api.delete_policy,
|
||||
uuid.uuid4().hex)
|
||||
|
||||
|
||||
class FilterTests(filtering.FilterTests):
|
||||
def test_list_entities_filtered(self):
|
||||
for entity in ['user', 'group', 'project']:
|
||||
|
|
|
@ -15,10 +15,10 @@
|
|||
|
||||
from keystone import exception
|
||||
from keystone.tests import unit
|
||||
from keystone.tests.unit import test_backend
|
||||
from keystone.tests.unit.policy import test_backends as policy_tests
|
||||
|
||||
|
||||
class RulesPolicy(unit.TestCase, test_backend.PolicyTests):
|
||||
class RulesPolicy(unit.TestCase, policy_tests.PolicyTests):
|
||||
def setUp(self):
|
||||
super(RulesPolicy, self).setUp()
|
||||
self.load_backends()
|
||||
|
|
|
@ -35,6 +35,7 @@ from keystone.tests.unit.assignment import test_backends as assignment_tests
|
|||
from keystone.tests.unit.catalog import test_backends as catalog_tests
|
||||
from keystone.tests.unit import default_fixtures
|
||||
from keystone.tests.unit.ksfixtures import database
|
||||
from keystone.tests.unit.policy import test_backends as policy_tests
|
||||
from keystone.tests.unit.resource import test_backends as resource_tests
|
||||
from keystone.tests.unit import test_backend
|
||||
from keystone.tests.unit.token import test_backends as token_tests
|
||||
|
@ -817,7 +818,7 @@ class SqlCatalog(SqlTests, catalog_tests.CatalogTests):
|
|||
region['id'])
|
||||
|
||||
|
||||
class SqlPolicy(SqlTests, test_backend.PolicyTests):
|
||||
class SqlPolicy(SqlTests, policy_tests.PolicyTests):
|
||||
pass
|
||||
|
||||
|
||||
|
|
Loading…
Reference in New Issue