- removes run_tests.sh since it's rarely used and an alternative exists
- removes all the remaining incubator files since nothing uses them
The real value of run_tests.sh over tox is that run_tests.sh enables
running tests against against any virtualenv or Python installation. tox
is just a tool that runs testr commands in a specific virtualenv. testr
can be used directly as a run_tests.sh replacement for running tests in
an arbitrary virtualenv or against any Python installation.
blueprint remove-oslo-incubator
Change-Id: I9d4ef8bf935eb565af1c8d53d1ed71be9a94a975
tools/pretty_tox.sh should be marked as executable, this patch
just 'chmod +x' to it.
Closes-Bug: 1486313
Change-Id: Ia5fa921e83da1e094970b1e44c9709272c7e32d3
When moving from keystone to openstack client, the initialization of
the ADMIN_USER variable was removed, making the script to fail.
Change-Id: Iee2d5b1cbed6c93e335a4b4dbad3034a2f8e29ed
When using openstack client to populate an initial keystone
deployment, instead of the former keystone client, the env.
variables needed are OS_TOKEN and OS_URL instead of the
previous OS_SERVICE_TOKEN and OS_SERVICE_ENDPOINT
Change-Id: I79dcd56896945267cf1c8ff4378ffff63048e155
The leading comment in sample_data.sh still references the old
python-keystoneclient when its python-openstackclient that is
used to populate sample data.
This patch also makes a minor fix of the Swift service description.
TrivialFix
Change-Id: Ie4f5729dcc0b3a6164470d11ba91ddaaec0bb022
The file has not been modified in 3 years, and seems like a
utility a deployer should maintain for debugging.
Change-Id: Ib4d55052c27facf7d96655c75784b657d1b01975
Cleans up the sample_data script to replace the keystoneclient commands
with the new openstackclient commands
Change-Id: Id68ff2b466e582a0c2f4418d173f7d63c14f5f37
Closes-Bug: #1459816
This switches keystone to use oslo-config-generator, where the contents
of our sample configuration file are configured using a configuration
file in config-generators/, because the only way to have tox create
files is to have configuration files for your configuration files
(seriously, it chokes when redirects are included in the command for a
test environment).
This also takes advantage of oslo-config-generator's ability to set the
line wrap width, which is done at 79 chars here to match the rest of our
code.
Also update the actual sample file under etc/
Change-Id: I9f9a157c7802c56a2c7484f6f4adec4aeb4071b8
Closes-Bug: 1324610
With the latest version of oslotest, we can now take advantage
of a common oslo_debug_helper script.
We can now remove our own homebrewed version, minor changes to
tox.ini were needed.
Change-Id: Ide72fb3531f0498dfe289d028049cd432aa08887
This syncs Keystone with oslo-incubator commit hash
e9bb0b596650540f336afb070a1f8c7de099721f .
In keystone:
$ rm -r keystone/openstack/common
In oslo-incubator:
$ git checkout e9bb0b596650540f336afb070a1f8c7de099721f
$ python update.py ../keystone
Commits
-------
bc48099 Log the function name of looping call
109e325 Use oslo.messaging to publish log errors
de4adbc pep8: fixed multiple violations
9651085 generator: remove unused param, small clean up
eac71f5 Fix common.log.ContextFormatter for Python 3
238e601 Make policy debug logging less verbose
250cd88 Fixed a new pep8 error and a small typo
5e3d3a5 Mask passwords included without quotes at the ends of commands
e7c8a45 Improve error handling for conf sample generation
9e88af1 fixed typos found by RETF rules
5f12bba Implement stop method in ProcessLauncher
0d7296f Add kwargs to jsonutils.load(s) functions
9c88dc3 file_open: fixed docstring to refer to open() instead of file()
d78b633 Fixes a simple spelling mistake
621d831 always log a traceback in the sys.excepthook
Change-Id: I4ef56ce08e1f3bbc0ddb82a495da153e09a14c50
Keystone's configuration should have no bearing on the catalog
for nova's port. Nova's port is "static" data from the templated
catalog perspective.
The 'compute_port' option has been marked as deprecated and
slated for removal in the L release. The default/sample
templated catalog files do not rely on this option any
longer.
Change-Id: I51b0ec951449360f002c2e7c900ded0f40e16044
Closes-Bug: #1335278
Now that bash8 is available on PyPI we can use it to clean up the bash
scripts in Keystone. This also uses bash8 in tox. For now we can add
files to the tox check manually as we make them compliant.
Change-Id: I87a7478949114163f0614b1a6d8b249e14afe0df
An upcoming change[1] in oslo's update.py adds new warnings for
style issues in the config. To compensate this commit:
- orders the modules alphabetically
- uses the script directive for scripts
Sync with oslo-incubator caed79d
This syncs Keystone with oslo-incubator commit hash
caed79d8239679cb74476bb0d9e5011b4fcc39da.
In keystone:
$ rm -r keystone/openstack/common
In oslo-incubator:
$ python update.py ../keystone
Commits
-------
1173e46 Remove ValueError when accessing sys.modules
17c4e21 Fix docstring indentation in systemd
90ae24b Remove redundant default=None for config options
6c7407b fileutils: port to Python 3
18f2bc1 Enforce unicode json output for jsonutils.load[s]()
af36c2a Fix logging setup for Python 3.4
5ae792b Document config generator variables
ea9ead8 Allow file exclusion in config generator
cdcc19c Mask passwords that are included in commands
9e5a393 jsonutils.load() accepts file pointer, not string
a6b2aec On Python <= 2.6, use simplejson if available
fe3389e Improve help strings
8a0f567 Remove str() from LOG.* and exceptions
f3f14c9 Fixed several typos
0f495ee Emit a log statement when releasing internal lock
9912e5d Add API for creating translation functions
1. https://review.openstack.org/76901
Change-Id: I89de9ae9e3c574095967a2a67e842a90b5527ffa
This syncs Keystone with oslo-incubator commit hash
2fd457bf2ccbeb2b84ffb204778b6417cd5405ba .
In keystone:
$ rm -r keystone/openstack/common
In oslo-incubator:
$ python update.py ../keystone
The newer lockutils requires posix_ipc. It's already in
global-requirements.
Keystone uses gettextutils and versionutils from oslo-incubator
so those should be in openstack-common.conf. They were pulled in
as dependencies of other oslo-incubator modules but Keystone
shouldn't rely on that.
Keystone doesn't use log_handler directly so that module was
removed from openstack-common.conf. log_handler is available in
the oslo.messaging library.
Change-Id: I6082f4e0995ca35372f9b061d8f76890aa93250c
Restructure the common config to include many help strings to
support using the oslo.config auto-generated sample config file.
Closes-Bug: #1229941
Change-Id: If352b3b816b1e7dc8b5fc3b9c1cb2adab187ffda
Sync in the oslo code for auto-config sample generation and
make the appropriate changes to setup to allow for automatic
option discovery.
`test-requirements.txt` now includes stevedore to
ensure the oslo libraries can all be loaded as expected.
Change-Id: Ieca0aea4d3c67b930c12467317d2f4d83763b601
We don't need vim modelines in each source file, it can be set in
user's vimrc.
Change-Id: Ie51ad62946afdf39eadcd59edaf8134ec10265c6
Closes-Bug: #1229324
Running a test with pdb was difficult because testr captures
output and causes pdb prompt to quit.
Tips for how to run with debug are provided here:
https://wiki.openstack.org/wiki/Testr#Debugging_.28pdb.29_Tests
This change puts these commands into a debug env in tox.ini so
you can do a command like
tox -e debug test_v3_trust_token_get_token_fails
or, for more granularity:
tox -e debug keystone.tests.test_sql_migrate_extensions.EndpointFilterExtension
tox -e debug keystone.tests.test_sql_migrate_extensions.EndpointFilterExtension.test_downgrade
and when it hits your breakpoint you'll get the debug prompt.
Change-Id: I2b5dc81f4652dc89ecbcc7c785245a81cf77a1ca
See I62ce43a330d7ae94eda4c7498782a655e63747fa for the gory details on
why this exists.
As of this fix:
https://github.com/eventlet/eventlet/pull/34
which was released in eventlet 0.13, we no longer need the patch.
This has now been removed from oslo-incubator, so this is really just
syncing that removal.
Change-Id: I84267f3c6726cb2e750f615e107c48b12c6ed353
According to keystoneclient/shell.py, --token and --endpoint (with
their accompanying ENV vars SERVICE_TOKEN and SERVICE_ENDPOINT)
were retained only for Essex compatibility and should have been
removed during Grizzly, replaced with --os-token (OS_SERVICE_TOKEN)
and --os-endpoint (OS_SERVICE_ENDPOINT).
This patch updates a couple of doc references to the old options,
and the sample_data tool.
Change-Id: I87060764f40b1612e3a440c3406d094536af4c9c
Swift now doesn't use 8888 port as any default service. And the origin
sample_data.sh always let new users to fail and modify swift bind port.
So switching 8888 port here to 8080 could generate sample data without
any change for building swift + keystone environment.
Closes-Bug: #1244304
Change-Id: If58f9f025f57565733aa25efc2fdf06865781391
This was abandoned once before: https://review.openstack.org/#/c/25781/
However this is not to do with packaging. This is required if we use
eventlet subprocess module (like we should be) in jenkins tests for
python2.6.
Also imports patch_tox_venv.py. This is a cutdown version of what would
happen in run_tests.sh but for tox environments which is how jenkins
runs tests now.
Change-Id: I369c3e464dfbe3a754f90db58785e97ac87b36c0
Rename tools/pip-requires to requirements.txt and tools/test-requires
to test-requirements.txt. These are standard files, and tools in the
general world are growing intelligence about them.
Fixes: bug #1179008
Change-Id: I1a19f0c73ab48987e2ff0dade1a57a68b65f0a22
Preserves the default passwords corresponding to the OpenStack Install
and Deploy Manual while allowing environment variables to specify user
provided passwords. As well, a single common password for all the service
users can be specified using the SERVICE_PASSWORD environment variable.
This fix restores compatibility with the version of this script released
in Folsom where the environment variables could override default passwords.
It also preserves compatibility with the fix for bug 1073291 that brought
the script into line with the docs (but unfortunately broke backwards
compatibility).
There is no warning emited if the user does not override the default
passwords as was present in Folsom, but not in Grizzly. This makes the
fix output compatible with Grizzly only. Note that the logic for warnings
pre-Grizzly was unclear. The script is, however, clearly named "sample"
and warnings are present in the comments.
Change-Id: I927fcddf04dcb87e5c9252f0874939b17f3c4809
Fixes: bug #1166182
Fixes bug #1128256
oslo.config has now been released to PyPI in time for Grizzly RC1 so
we can switch to using it directly.
Change-Id: I655f831718ae5f4e25e941ee206fe195214a9a91
Fixes bug #1133240
keystone has always pinned the pam dependency to 0.1.4
pam>=0.1.4
this version was released in November 2009 and there hasn't been a
release since. I can't even find a version control repo for the
project.
There's no particular reason to expect a future version would break us
and, indeed, we want to find out about it if it happens.
Change-Id: I2becf47c9d2566e2c3496ae15ca886b737006a92
The Ec2Signer class has been moved to python-keystoneclient,
so we can remove the internal implementation and import the
keystoneclient version
blueprint ec2signer-to-keystoneclient
Change-Id: I19d8575ab8b972467ce280a6197ae762da1ce790
Update the version of oslo-config in pip-requires. This update includes
a fix for a bug that breaks oslo.config imports.
Change-Id: I2e31d3980c495b1fd16db5488c7d3c982ce069ac