Bump hacking, other flake8 plugins
Address the couple of small issues it highlights. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Change-Id: I0b0b8ff96d024cc3432ce902e781fff7e594924e
This commit is contained in:
parent
9df23dc6a8
commit
b68be4b70e
|
@ -33,4 +33,4 @@ def check_oslo_namespace_imports(logical_line, blank_before, filename):
|
||||||
msg = ("K333: '%s' must be used instead of '%s'.") % (
|
msg = ("K333: '%s' must be used instead of '%s'.") % (
|
||||||
logical_line.replace('oslo.', 'oslo_'),
|
logical_line.replace('oslo.', 'oslo_'),
|
||||||
logical_line)
|
logical_line)
|
||||||
yield(0, msg)
|
yield (0, msg)
|
||||||
|
|
|
@ -112,7 +112,7 @@ class Opt(object):
|
||||||
|
|
||||||
def __eq__(self, other):
|
def __eq__(self, other):
|
||||||
"""Define equality operator on option parameters."""
|
"""Define equality operator on option parameters."""
|
||||||
return (type(self) == type(other) and
|
return (type(self) is type(other) and
|
||||||
self.name == other.name and
|
self.name == other.name and
|
||||||
self.type == other.type and
|
self.type == other.type and
|
||||||
self.help == other.help and
|
self.help == other.help and
|
||||||
|
|
|
@ -73,7 +73,7 @@ class BoolType(object):
|
||||||
def __eq__(self, other):
|
def __eq__(self, other):
|
||||||
"""Define equiality for many bool types."""
|
"""Define equiality for many bool types."""
|
||||||
# hack around oslo.config equality comparison
|
# hack around oslo.config equality comparison
|
||||||
return type(self) == type(other)
|
return type(self) is type(other)
|
||||||
|
|
||||||
# NOTE: This function is only needed by Python 2. If we get to point where
|
# NOTE: This function is only needed by Python 2. If we get to point where
|
||||||
# we don't support Python 2 anymore, this function should be removed.
|
# we don't support Python 2 anymore, this function should be removed.
|
||||||
|
|
|
@ -1,6 +1,6 @@
|
||||||
hacking~=4.1.0 # Apache-2.0
|
hacking~=6.1.0 # Apache-2.0
|
||||||
flake8-docstrings~=1.6.0 # MIT
|
flake8-docstrings~=1.7.0 # MIT
|
||||||
flake8-import-order>=0.17.1 #LGPLv3
|
flake8-import-order~=0.18.2 #LGPLv3
|
||||||
bandit~=1.7.6 # Apache-2.0
|
bandit~=1.7.6 # Apache-2.0
|
||||||
|
|
||||||
coverage!=4.4,>=4.0 # Apache-2.0
|
coverage!=4.4,>=4.0 # Apache-2.0
|
||||||
|
|
Loading…
Reference in New Issue