Update patch set 17
Patch Set 17: (4 comments) Patch-set: 17 Attention: {"person_ident":"Gerrit User 32553 \u003c32553@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 13252 \u003c13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_13252\u003e replied on the change"}
This commit is contained in:
parent
88826ab96d
commit
3965f8ab99
|
@ -191,6 +191,30 @@
|
|||
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "13c71c34_da7137da",
|
||||
"filename": "ansible/group_vars/all.yml",
|
||||
"patchSetId": 14
|
||||
},
|
||||
"lineNbr": 1133,
|
||||
"author": {
|
||||
"id": 13252
|
||||
},
|
||||
"writtenOn": "2023-06-16T08:42:10Z",
|
||||
"side": 1,
|
||||
"message": "hmm, o.k., let\u0027s start with what we have and then iterate",
|
||||
"parentUuid": "5ae428cb_e4d88d8d",
|
||||
"range": {
|
||||
"startLine": 1133,
|
||||
"startChar": 65,
|
||||
"endLine": 1133,
|
||||
"endChar": 115
|
||||
},
|
||||
"revId": "37fdad4b14161ac1cbb7aae09464f7cbf1ebb4db",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
@ -0,0 +1,61 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "013ed527_8cf081f6",
|
||||
"filename": "ansible/roles/prometheus/tasks/config.yml",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 286,
|
||||
"author": {
|
||||
"id": 13252
|
||||
},
|
||||
"writtenOn": "2023-06-16T08:42:10Z",
|
||||
"side": 1,
|
||||
"message": "this would better be a more specific name, like \"ovn-exporter-config\"? or even \"prometheus-ovn-exporter-config\"?",
|
||||
"range": {
|
||||
"startLine": 286,
|
||||
"startChar": 68,
|
||||
"endLine": 286,
|
||||
"endChar": 75
|
||||
},
|
||||
"revId": "3adae47cb46697859048be891443cd5ad027c5a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "03b00aae_67115fb2",
|
||||
"filename": "etc/kolla/globals.yml",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 733,
|
||||
"author": {
|
||||
"id": 13252
|
||||
},
|
||||
"writtenOn": "2023-06-16T08:42:10Z",
|
||||
"side": 1,
|
||||
"message": "nit: no need for an extra empty line",
|
||||
"revId": "3adae47cb46697859048be891443cd5ad027c5a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ef0e37e9_60e3e9ce",
|
||||
"filename": "tests/templates/globals-default.j2",
|
||||
"patchSetId": 17
|
||||
},
|
||||
"lineNbr": 179,
|
||||
"author": {
|
||||
"id": 13252
|
||||
},
|
||||
"writtenOn": "2023-06-16T08:42:10Z",
|
||||
"side": 1,
|
||||
"message": "Would it be possible (and make sense) to just deploy OVN in this scenario without having neutron on top?\n\nThat would avoid having to deploy prometheus in the OVN scenario just for testing this exporter.\n\nI think we can defer this question to a follow-up if you just drop this line for now.",
|
||||
"revId": "3adae47cb46697859048be891443cd5ad027c5a5",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue