openstack
/
kolla-ansible
Code Issues Proposed changes

Fix broken list concatenation in horizon role 

Starting with ansible-core 2.13, list concatenation format is changed
and does not support concatenation operations outside of the jinja template.

The format change:

  "[1] + {{ [2] }}" -> "{{ [1] + [2] }}"

This affects the horizon role that iterates over existing policy files to
override and concatenate them into a single variable.

Co-Authored-By: Dr. Jens Harbott <harbott@osism.tech>

Closes-Bug: #2045660
Change-Id: I91a2101ff26cb8568f4615b4cdca52dcf09e6978
(cherry picked from commit 97cd173177)
This commit is contained in:
Andrey Kurilin 2023-11-23 15:24:08 +01:00 committed by Michal Arbet
parent a8c3bd004e
commit 4d649e3daf
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/roles/horizon/tasks/policy_item.yml
View File

@ -20,6 +20,6 @@
- name: Update custom policy file name
set_fact:
custom_policy: "{{ custom_policy }} + [ '{{ overwritten_files.results.0.stat.path }}' ]"
custom_policy: "{{ custom_policy + [overwritten_files.results.0.stat.path] }}"
when:
- overwritten_files.results

7
releasenotes/notes/bug-2045660-inability-to-override-horizon-policy-files-c405906a9faf8f3b.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- |
Starting with ansible-core 2.13, list concatenation format is changed
which resulted in inability to override horizon policy files.
See `LP#2045660 <https://launchpad.net/bugs/2045660>`__
for more details.