openstack/kolla-ansible
Code Issues Proposed changes

Stop mocking ansible modules globally

Browse Source 
This causes non-local side effects that are hard to track down. E.g:

--- import errors ---
Failed to import test module: tests.test_merge_yaml
Traceback (most recent call last):
  File "/home/will/.pyenv/versions/3.7.7/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/will/.pyenv/versions/3.7.7/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/will/code/kolla-ansible/tests/test_merge_yaml.py", line 19, in <module>
    from ansible.errors import AnsibleModuleError
ModuleNotFoundError: No module named 'ansible.errors'; 'ansible' is not a package

This `'ansible' is not a package` message occurs because ansible is a Mock.

Depends-On: https://review.opendev.org/#/c/726768/
Change-Id: Iddbdd3d855daadbf12536cc990559e6b8e123051
This commit is contained in:
Will Szumski
2020-05-07 10:18:37 +01:00
parent a5c1d36626
commit 4fcbdd7740
4 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lower-constraints.txt
View File

@@ -1,4 +1,5 @@
alabaster==0.7.10
ansible==2.8.0
appdirs==1.4.3
asn1crypto==0.24.0
Babel==2.5.3