Update patch set 27
Patch Set 27:
(6 comments)
Patch-set: 27
Attention: {"person_ident":"Gerrit User 32553 \u003c32553@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32553\u003e replied on the change"}
This commit is contained in:
Gerrit User 32553
Gerrit Code Review
parent
bd2725900e
commit
5a30ec4a3b
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "6aae7b31_8d9f7781",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 27
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-26T13:31:12Z",
|
||||
"side": 1,
|
||||
"message": "All tests are green now, except for ARM - see my other comment.",
|
||||
"revId": "0506b3829506da45bf21620663d1b2fd5c786c4e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -33,6 +33,24 @@
|
|||
"message": "Okay, so it seems this is really missing the sockets in our deployment:\n\nhttps://github.com/greenpau/ovn_exporter/issues/10\nhttps://github.com/greenpau/ovn_exporter/issues/11\n\nI don\u0027t know why these issues where opened to be honest, as we imho can just bindmount the socket in kolla.\n\nI\u0027ll work on that.",
|
||||
"revId": "2bd13070b20cc7c0e50d81067b75fa88e5559901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f41beb5a_c885fe0d",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 23
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-26T13:31:12Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "3331f62f_3effad38",
|
||||
"revId": "2bd13070b20cc7c0e50d81067b75fa88e5559901",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -191,6 +191,24 @@
|
|||
"parentUuid": "b1942458_fbf23c9e",
|
||||
"revId": "536a962a5a64a79520f38cf86726943bc40c155f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "560f105a_3f36b2c4",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-26T13:31:12Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "eb9cd0e0_1a057d05",
|
||||
"revId": "536a962a5a64a79520f38cf86726943bc40c155f",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -50,6 +50,24 @@
|
|||
"message": "now I feel a little dumb, prometheus_openstack_exporter doesn\u0027t seem to be tested anywhere, it was explicitly disabled - without a comment as to why - in https://review.opendev.org/c/openstack/kolla-ansible/+/740083/8..10/tests/templates/globals-default.j2\n\ndisabling it thus here as well.",
|
||||
"revId": "8b580f09f89e76b8322c434a4b692664483ffd33",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "810cfc18_1f505f1a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 26
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-26T13:31:12Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "13fb0b62_b3bd738c",
|
||||
"revId": "8b580f09f89e76b8322c434a4b692664483ffd33",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -16,6 +16,24 @@
|
|||
"message": "I have a suspicion that the `enable_ovn` flag itself is already broken in CI somehow (I didn\u0027t find any other test that actually sets this to \"yes\" just yet).\n\nTesting in https://review.opendev.org/c/openstack/kolla-ansible/+/913838",
|
||||
"revId": "966be884638613350ac1d6280ff71e7849de92d7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "07088e25_afd741c3",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 24
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-26T13:31:12Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "b8d0a743_51205e8c",
|
||||
"revId": "966be884638613350ac1d6280ff71e7849de92d7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
|
@ -34,6 +34,24 @@
|
|||
"parentUuid": "67bd96cc_7674ac83",
|
||||
"revId": "f02305406c26c399a20c4d3c06a748e11db3d25b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "5edcd4d8_ab20cef1",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 18
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 32553
|
||||
},
|
||||
"writtenOn": "2024-03-26T13:31:12Z",
|
||||
"side": 1,
|
||||
"message": "so I rearranged everything a little bit. This is now tested in the \"ovn\" scenario, as this was the easiest way to make the tests green, which was my primary goal for now, to have this even passing and hopefully get it merged.\n\nPlease take a look @frickler@offenerstapel.de and @mnasiadka@gmail.com if my solution is acceptible.\n\nI investigated the rabbitmq podman container failure on ARM, but I have not really found a clue there just yet. Seems unrelated as at least the rabbitmq log itself is happy.\n\nThat being said, I don\u0027t know how important the ARM tests are, as they are also non voting - which doesn\u0027t really tell anything it seems, when it comes to importance of tests.",
|
||||
"parentUuid": "43fe06b8_8d1beff2",
|
||||
"revId": "f02305406c26c399a20c4d3c06a748e11db3d25b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue