openstack/kolla-ansible
Code Issues Proposed changes

CI: future-proof return semantics in check-failure.sh

Browse Source 
In case we add further check functions, use a return rather than exit.

Change-Id: Ie2a53028802ecde628bc9fe0b4e3236bdb588cf9
This commit is contained in:
Mark Goddard 2021-10-04 09:08:15 +01:00 committed by Radosław Piliszek
parent 1d0171fc70
commit 613b00cccf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/check-failure.sh
View File

@ -30,7 +30,7 @@ check_failure() {
# NOTE(mgoddard): monasca-thresh is a one-shot container that exits but # NOTE(mgoddard): monasca-thresh is a one-shot container that exits but
# remains in place, leaving it with a status of exited. This is harmless. # remains in place, leaving it with a status of exited. This is harmless.
if [[ "$failed_containers" = "monasca_thresh" ]]; then if [[ "$failed_containers" = "monasca_thresh" ]]; then
exit 0 return
fi fi
if [[ -n "$failed_containers" ]]; then if [[ -n "$failed_containers" ]]; then