openstack/kolla-ansible
Code Issues Proposed changes

Fix the upgrade issue when image id is the same

Browse Source 
When image id is the same, the container won't re-create with the
latest image tag.

Change-Id: I402ad275c388006248cb559851b01b0b963cf170
Closes-Bug: #1569723
This commit is contained in:
Jeffrey Zhang 2016-04-13 17:56:29 +08:00
parent 030619535e
commit 9575417b15
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ansible/library/kolla_docker.py
View File

@ -288,6 +288,7 @@ class DockerWorker(object):
def compare_image(self, container_info=None):
container_info = container_info or self.get_container_info()
parse_repository_tag = docker.utils.parse_repository_tag
if not container_info:
return True
new_image = self.check_image()
@ -296,6 +297,11 @@ class DockerWorker(object):
return True
if new_image['Id'] != current_image:
return True
# NOTE(Jeffrey4l) when new image and the current image have
# the same id, but the tag name different.
elif (parse_repository_tag(container_info['Config']['Image']) !=
parse_repository_tag(self.params.get('image'))):
return True
def compare_labels(self, container_info):
new_labels = self.params.get('labels')