openstack
/
kolla-ansible
Code Issues Proposed changes

Add basic checking for network_interface to prechecks 

Add the following prechecks for network_interface:

* Check it exists on the node
* Check its up
* Check it has an IP associated

TrivialFix
Change-Id: I86f1d79d8592a3b108822e7d19541f91a1c0d716
Co-Authored-By: James McCarthy <james.m.mccarthy@oracle.com>
This commit is contained in:
Paul Bourke 2016-08-15 14:59:58 +00:00
parent 6ea99983fc
commit a01b803b53
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ansible/roles/prechecks/tasks/port_checks.yml
View File

@ -448,3 +448,19 @@
failed_when: "'169.254.' not in kolla_internal_vip_address and \
kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3]) is none"
when: enable_haproxy | bool
- name: Checking the network_interface is present
fail: "msg='Please check the network_interface property - interface {{ network_interface }} not found'"
when: network_interface not in ansible_interfaces
- name: Checking the network_interface is active
fail: "msg='Please check the network_interface settings - interface {{ network_interface }} is not active'"
when: hostvars[inventory_hostname]['ansible_' + network_interface]['active'] != True
- name: Checking the network_interface configuration
fail: "msg='Please check the network_interface settings - interface {{ network_interface }} configuration missing'"
when: hostvars[inventory_hostname]['ansible_' + network_interface]['ipv4'] is not defined
- name: Checking the network_interface ip address configuration
fail: "msg='Please check the network_interface settings - interface {{ network_interface }} ip address problem'"
when: hostvars[inventory_hostname]['ansible_' + network_interface]['ipv4']['address'] is not defined

3
releasenotes/notes/add-network-interface-checks-0e789f3f93cbdb09.yaml Normal file
View File

@ -0,0 +1,3 @@
---
features:
- Add some extra prechecks to ensure a sane NIC config.