openstack/kolla-ansible
Code Issues Proposed changes

Fix on setting enable_openvswitch

Browse Source 
In the default expression which sets enable_openvswitch, the boolean filter
is applied only on 'linuxbridge', not on the whole comparing expression. So
even if neutron_plugin_agent is set to 'linuxbridge', but enable_openvswitch
is not explicitly set to "no" (e.g., in globals.yml), then enable_openvswitch
is eventually set to true, and openvswitch role is unintentionally applied.
Boolean filter is not really necessary on the comparing expression, so it can
be removed just like in globals.yml.

Change-Id: I0612346484eada8192ee03dc9d5057cb6881f532
Closes-bug: #1747136
This commit is contained in:
Chulmin Kang 2018-10-13 03:10:50 +09:00
parent 5bfcb58427
commit b854308328
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/group_vars/all.yml
View File

@ -514,7 +514,7 @@ enable_nova_ssh: "yes"
enable_octavia: "no"
enable_onos: "no"
enable_opendaylight: "no"
enable_openvswitch: "{{ neutron_plugin_agent != 'linuxbridge' | bool }}"
enable_openvswitch: "{{ neutron_plugin_agent != 'linuxbridge' }}"
enable_ovs_dpdk: "no"
enable_osprofiler: "no"
enable_panko: "no"