openstack/kolla-ansible
Code Issues Proposed changes

Do not write octavia_amp_ssh_key if auto_config disabled

Browse Source 
This task is writing private key from passwords to
/etc/kolla/octavia-worker/{{ octavia_amp_ssh_key_name }} even
if user disabled octavia auto configure.

This patch is adding conditional for this task and skipping
it if octavia_auto_configure: "no".

Closes-Bug: #1927727

Change-Id: Ib993b387d681921d804f654bea780a1481b2b0d0
(cherry picked from commit 41fe771bcc)
This commit is contained in:
Michal Arbet
2021-05-07 14:10:46 +02:00
committed by Mark Goddard
parent 0013f85ffd
commit deafe00dd2
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ansible/roles/octavia/tasks/config.yml
View File

@@ -110,7 +110,9 @@
group: "{{ config_owner_group }}" group: "{{ config_owner_group }}"
mode: "0400" mode: "0400"
become: True become: True
when: inventory_hostname in groups[octavia_services['octavia-worker']['group']] when:
- inventory_hostname in groups[octavia_services['octavia-worker']['group']]
- octavia_auto_configure | bool
- name: Copying certificate files for octavia-worker - name: Copying certificate files for octavia-worker
vars: vars:

6
releasenotes/notes/bug-1927727-4437103de59e85e5.yaml Normal file
View File

@@ -0,0 +1,6 @@
---
fixes:
- |
Fixes an issue with Octavia SSH key copying if user disabled Octavia
auto configuration.
`LP##1927727 <https://bugs.launchpad.net/kolla-ansible/+bug/1927727>`__